Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): add social logins (github, google) #74

Closed
wants to merge 15 commits into from

Conversation

kymppi
Copy link
Contributor

@kymppi kymppi commented Aug 26, 2022

Issues: #18 #36

TODO:

  • Github Login Button (styling)
  • Add Github provider
  • Add required environment variables
  • Google Login Button
  • Add Google Provider
  • Add required environment variables

@kymppi kymppi changed the title feat(github): add github login feat(github): add github login #18 Aug 26, 2022
@kymppi kymppi changed the title feat(github): add github login #18 feat(github): add social logins (github, google) Aug 26, 2022
@kymppi kymppi marked this pull request as ready for review August 26, 2022 16:14
@kymppi
Copy link
Contributor Author

kymppi commented Aug 26, 2022

Current preview:
image
image

Fully functional 🎉

@kymppi
Copy link
Contributor Author

kymppi commented Aug 26, 2022

There seems to be problems when creating a form after user has signed up with google

@kymppi kymppi marked this pull request as draft August 26, 2022 16:43
@kymppi
Copy link
Contributor Author

kymppi commented Aug 26, 2022

Problem: when signing up with social, the user is not saved to the database by next-auth

@mattinannt
Copy link
Member

@kymppi thanks a lot for this PR 🤗 Looks great! Sorry that it took so long for me to get to it. I will check with next-auth and prisma how to make the database integration and how to migrate snoopForms to make this work 😊

@kymppi
Copy link
Contributor Author

kymppi commented Oct 20, 2022

@mattinannt Any progress?

@mattinannt
Copy link
Member

@kymppi With our transition to Formbricks HQ I went through your code and built the remaining parts on the next-auth side into Formbricks HQ and added the Github provider. Thanks for tackling this challenge 💪
We now have Github Auth built within Formbricks HQ (releasing next week) and I'm closing this PR now.

@mattinannt mattinannt closed this Dec 2, 2022
@kymppi
Copy link
Contributor Author

kymppi commented Dec 2, 2022

Awesome! 🎉 If there's something i could help with, contact me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants