Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WebsiteQuestion Component #98

Closed
mattinannt opened this issue Oct 10, 2022 · 2 comments · Fixed by #120
Closed

Refactor WebsiteQuestion Component #98

mattinannt opened this issue Oct 10, 2022 · 2 comments · Fixed by #120
Labels
enhancement New feature or request good first issue Good for newcomers 🙋🏻‍♂️help wanted Extra attention is needed

Comments

@mattinannt
Copy link
Member

Refactor/Rewrite the WebsiteQuestion Component of EditorJS/NoCode-Editor to be better maintainable.

The WebsiteQuestion Component (snoopforms/components/editorjs/tools/WebsiteQuestion.tsx) was build using an old pattern for EditorJS. New Components like the MultipleChoiceQuestion use a new approach which works much better with React. The old components needs to be refactored / rewritten to work using the newer approach.
For that you can copy a newer component as a scaffolding and insert the logic and UI components of the WebsiteQuestion.
@kymppi
Copy link
Contributor

kymppi commented Oct 20, 2022

Hey im currently working on this. PR in an hour :P

@kymppi kymppi mentioned this issue Oct 20, 2022
Merged
@kymppi
Copy link
Contributor

kymppi commented Oct 20, 2022

#120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers 🙋🏻‍♂️help wanted Extra attention is needed
Projects
No open projects
🦝 snoopForms Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: phone, website, number components, add: nixos development rittaschool/formbricks
2 participants
@mattinannt @kymppi