Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When will you refactor the Data Model? #12

Closed
DoanhPoPu opened this issue Nov 3, 2019 · 3 comments
Closed

When will you refactor the Data Model? #12

DoanhPoPu opened this issue Nov 3, 2019 · 3 comments

Comments

@DoanhPoPu
Copy link

I'm using xlsx as data sources and would like to remove the variable pattern as current. If we can remove $ or @ so it will be more friendly with manual tester and the old files they had.
I love your lib but we need to improve more so the community can use easily.

Thanks,
Doanh Nguyen

@Snooz82
Copy link
Owner

Snooz82 commented Nov 3, 2019

You can create your own DataReader. It is quite easy.

https://github.com/Snooz82/robotframework-datadriver/blob/master/Readme.rst#custom-datareader-classes

When you want to have a XLS-Reader that does not require variable syntax, you have to override/implement the method _analyse_header in your custom reader.

You can copy it from Abstract_Data_Reader .
And not use the _is_variable() method.

For CSV there is the generic_csv_reader.py .
This one requires nothing. It just takes all columns as Variables.

I prefer the variable syntax, because the link is clear.
In the future @ and & will also be available to support lists and dictionaries.

Regards.

@Snooz82
Copy link
Owner

Snooz82 commented Nov 3, 2019

If you have implemented a generic_xls_reader, please create a pull request, then i will include it into the project

@DoanhPoPu
Copy link
Author

Thanks Snooz82. So I will keep the variable pattern as current, I will modify the old xlsx data sources into new pattern as the lib required.
Thanks for your valuable lib ;)

@Snooz82 Snooz82 closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants