Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PostGIS #18

Closed
wants to merge 2 commits into from
Closed

Add support for PostGIS #18

wants to merge 2 commits into from

Conversation

dbaty
Copy link
Member

@dbaty dbaty commented Aug 23, 2017

PostGIS is an extension for PostgreSQL. Django supports it (django.contrib.gis.db.backends.postgis). This pull request aims at providing a custom CID-enabled backend for PostGIS.

Other backends are not tested (and I can see why), this one does not either. Let's say I aimed for homogeneity. ;)

@a-musing-moose : do you think that it might make sense to add that to django-cid itself? As PostGIS is supported by Django, I think it's fair enough.

@coveralls
Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage decreased (-3.8%) to 63.551% when pulling 1e58983 on Polyconseil:dbaty/postgis_backend into 7215fcd on snowball-one:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 63.551% when pulling 1e58983 on Polyconseil:dbaty/postgis_backend into 7215fcd on snowball-one:master.

One may now use `cid.backends.postgis` to enable correlation ids when
using a PostGIS database (replacing Django-provided
`django.contrib.gis.db.backends.postgis`).
@dbaty
Copy link
Member Author

dbaty commented Nov 10, 2017

I updated the branch (it's now up-to-date) and added Django 1.11 compatibility (the create_cursor() take arguments in Django 1.11).

We have been using this on production since August without any issue. @tangent-au-deployment or @a-musing-moose : do you think that you could merge this branch to master and cut a new release?

@dbaty
Copy link
Member Author

dbaty commented Aug 30, 2018

Merged in a77ae60.

@dbaty dbaty closed this Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants