Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awareness of inverse roles, e.g. inverse of 'domain' is 'mod' #10

Open
kovvalsky opened this issue Mar 5, 2018 · 1 comment

Comments

@kovvalsky
Copy link

commented Mar 5, 2018

Currently Smatch is not aware that mod is the inverse role of domain. Also it has simplistic treatment of inverse roles. ROLE-of is always converted to ROLE.
This rule in some cases produces non-existing roles, e.g., these are primary roles consist-of, prep-on-behalf-of or prep-out-of, and their reduced versions are not AMR roles.
See the AMR issue

@snowblink14

This comment has been minimized.

Copy link
Owner

commented Mar 11, 2018

mod becomes the inverse of domain quite recently so smatch hasn't caught up yet. This probably just needs a rule change.
Combined with the fact that now we have "-of" in primary rules, it might be easier to extend as AMR evolves if we use a file to store role names and their inverse, and read/validate them in AMR (i.e. separating the validation and computing module).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.