Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Deterministic wallets? #48

Closed
fireduck64 opened this issue Jun 3, 2018 · 5 comments
Closed

Improvement: Deterministic wallets? #48

fireduck64 opened this issue Jun 3, 2018 · 5 comments
Labels
ENHANCEMENT New feature or request PRIORITY MEDIUM Medium priority

Comments

@fireduck64
Copy link
Member

So we can do deterministic wallets bip39 style from a seed and HD derivation like other things for EC keys.
That is no problem.

It would be nice to do it for non-EC keys as well, but the part with the xpub deriving addresses without the need of the private key is EC-only magic. But we don't really need that, we could do derivable non-EC keys with using the seed to feed into a deterministic PRNG and then have that used as the SecureRandom to generate other types of keys.

There are problems that probably make this a bad idea:

  • If the key generation does any sort of floating point or per-platform/environment optimization it could generate different addresses on different machines/platforms/environments.
  • If the key generation algorithm changes in any ways, we will almost certainly generate different keys.

This isn't the sort of thing we can screw around on. Probably a bad idea.

@cluelessperson cluelessperson added ENHANCEMENT New feature or request PRIORITY MEDIUM Medium priority labels Jun 4, 2018
@tynes
Copy link

tynes commented Nov 3, 2018

I would really like to see this as the UX around coins that don't support some type of bip39 style key derivation isn't always the best. It sounds like you know about this: https://github.com/satoshilabs/slips/blob/master/slip-0010.md

@fireduck64
Copy link
Member Author

@tynes I understand completely. I really enjoy seed based deterministic wallets and use them almost exclusively in other coins.

I could make EC only wallets that support deterministic generation but then how people save a wallet depends on what time of wallet it is and I concerned about that sort of confusion.

It is absolutely still on my mine.

@fireduck64
Copy link
Member Author

Bam.

@tynes
Copy link

tynes commented Jan 16, 2019

Did you merge in support?

I see here: b50c4f3

Do you have a registered coin type? I don't see snowblossom on this list
https://github.com/satoshilabs/slips/blob/master/slip-0044.md

@fireduck64
Copy link
Member Author

Yes, it is in 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCEMENT New feature or request PRIORITY MEDIUM Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants