Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #4

Open
7 tasks
pvanliefland opened this issue Aug 23, 2013 · 0 comments
Open
7 tasks

Refactor #4

pvanliefland opened this issue Aug 23, 2013 · 0 comments

Comments

@pvanliefland
Copy link
Member

  • Stop using "namespaces" for indices. Indexes should have a full qualified names, and dev / staging / prod indices should not reside in the same elasticsearch cluster
  • Remove the search() method from the Service class. It has no added value over straightforward elastica usage and is less flexible. The only reason it is there now is to add the pseudo index namespaces
  • Remove the client class - now that Elastica supports PSR0 namespaces, it has no use whatsoever (See Compatibility with new version of Elastica #1)
  • Once this is done, refactor the paginator so that is does not use the Service class anymore - only a Client and a Query (see next item)
  • The paginator should either use a search object rather than a client and a query, or be able to receive multiple indices and optionally multiple types
  • The getResultSet method should be removed from the paginator class
  • The Service class should maybe be given another name, if it only deals with indexing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant