Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest.connection.RequestBuilder is overly restrictive on requestId parameters #593

Open
nicholasdgoodman opened this issue Sep 30, 2023 · 0 comments

Comments

@nicholasdgoodman
Copy link

Background

According to the official file data ingestion API documentation is described as:

requestId: (required No) String used to track requests through the system. We recommend providing a random string with each request, e.g. a UUID.

This clearly indicates an insertFiles request should not have to supply a request ID, but also, that a UUID is only recommended but not required.

However, as written, there way to invoke RequestBuilder.generateInsertRequest(...) without providing an externally generated UUID.

Implementors should be allowed to provide any string value to this argument, or optionally not supply one at all.

Feature Request

Requesting any of the following:

  • additional overloads of RequestBuilder.generateInsertRequest(...) and RequestBuilder.generateHistoryRequest(...) which accept a requestId as a String parameter
  • permit null or "" values for requestId parameters on these methods, or provide additional method overloads without these arguments

or

  • Open up most or all private methods in class RequestBuilder to allow implementers extend this functionality themselves
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants