slf4j configuration is broken due to shade relocation

[ooasis]

It seems slf4j is broken due to shade relocation process.

Trying to use logback with slf4j and always get following error:

    SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
    SLF4J: Defaulting to no-operation (NOP) logger implementation
    SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Looking into the cause, it is due to shade relocation process changed this line:

net.snowflake.client.jdbc.internal.org.slf4j.LoggerFactory

L47:   private static String STATIC_LOGGER_BINDER_PATH = 
  "net/snowflake/client/jdbc/internal/org/slf4j/impl/StaticLoggerBinder.class";

This should be "org/slf4j/impl/StaticLoggerBinder.class" to match the slf4j's init process.

[ooasis]

Submitted a PR #17

[howryu]

Thanks for your reporting and contribution. I need to discuss with the team whether we should go this way or not.

[ooasis]

If a library is only used internally for your implementation, it is ok to relocate it to avoid version conflicts. For the case of logging, usually people would like to have an unified configuration cross entire application (this is one of the reason to use SLF4J), so it is better to give application developer more control. SLF4J has been around long enough, so I would not expect to have big issue with version conflicts.