Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index copy #1786

Merged
merged 9 commits into from
Jun 20, 2024
Merged

Index copy #1786

merged 9 commits into from
Jun 20, 2024

Conversation

sfc-gh-samdesai1
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1458120

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

Implements Index.copy

@sfc-gh-samdesai1 sfc-gh-samdesai1 added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Jun 15, 2024
@sfc-gh-samdesai1 sfc-gh-samdesai1 marked this pull request as ready for review June 18, 2024 21:15
@sfc-gh-samdesai1 sfc-gh-samdesai1 requested a review from a team as a code owner June 18, 2024 21:15
sfc-gh-yzou
sfc-gh-yzou reviewed Jun 20, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/index.py Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/index.py Show resolved Hide resolved
tests/integ/modin/index/test_index_methods.py Outdated Show resolved Hide resolved
@sfc-gh-samdesai1 sfc-gh-samdesai1 merged commit 56f207a into main Jun 20, 2024
37 checks passed
@sfc-gh-samdesai1 sfc-gh-samdesai1 deleted the samdesai-SNOW-1458120-copy branch June 20, 2024 22:10
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@sfc-gh-lspiegelberg
Copy link
Contributor

sfc-gh-lspiegelberg commented Jun 20, 2024 •
edited
Loading

Can we have for the next PR pls a JIRA ticket + a meaningful description (when merging) @sfc-gh-samdesai1 ? This helps us troubleshoot in case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-dpetersohn sfc-gh-dpetersohn sfc-gh-dpetersohn approved these changes

@sfc-gh-nkrishna sfc-gh-nkrishna Awaiting requested review from sfc-gh-nkrishna

@sfc-gh-vbudati sfc-gh-vbudati Awaiting requested review from sfc-gh-vbudati

@sfc-gh-yzou sfc-gh-yzou Awaiting requested review from sfc-gh-yzou

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sfc-gh-samdesai1 @sfc-gh-lspiegelberg @devin-petersohn @sfc-gh-azhan @sfc-gh-yzou @sfc-gh-vbudati @sfc-gh-dpetersohn @sfc-gh-nkrishna