Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1445866]: Add support for DataFrame.assign #1825

Merged
merged 9 commits into from
Jun 25, 2024
Merged

[SNOW-1445866]: Add support for DataFrame.assign #1825

merged 9 commits into from
Jun 25, 2024

Conversation

sfc-gh-rdurrani
Copy link
Contributor

@sfc-gh-rdurrani sfc-gh-rdurrani commented Jun 24, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1445866

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

Adds support for the DataFrame.assign API.

@sfc-gh-rdurrani sfc-gh-rdurrani requested a review from a team as a code owner June 24, 2024 21:58
sfc-gh-nkrishna
sfc-gh-nkrishna reviewed Jun 24, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-nkrishna
Copy link
Contributor

@sfc-gh-rdurrani I'd suggest you rebase this PR on latest main, your build doc failure will get resolved

@sfc-gh-rdurrani sfc-gh-rdurrani enabled auto-merge (squash) June 25, 2024 20:47
@sfc-gh-helmeleegy
Copy link
Contributor

Can we update the PR description?

sfc-gh-helmeleegy
sfc-gh-helmeleegy reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just left a couple of nits.

sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Rehan!

@sfc-gh-rdurrani sfc-gh-rdurrani merged commit 431a153 into main Jun 25, 2024
35 checks passed
@sfc-gh-rdurrani sfc-gh-rdurrani deleted the rdurrani-SNOW-1445866 branch June 25, 2024 23:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-dpetersohn sfc-gh-dpetersohn Awaiting requested review from sfc-gh-dpetersohn sfc-gh-dpetersohn is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfc-gh-rdurrani @sfc-gh-nkrishna @sfc-gh-helmeleegy