Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-797214 Fix flaky test for table.py #793

Merged
merged 2 commits into from
Apr 19, 2023
Merged

SNOW-797214 Fix flaky test for table.py #793

merged 2 commits into from
Apr 19, 2023

Conversation

sfc-gh-sfan
Copy link
Collaborator

@sfc-gh-sfan sfc-gh-sfan commented Apr 18, 2023

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-797214

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Fix flaky test

@sfc-gh-sfan sfc-gh-sfan requested review from a team, sfc-gh-yixie and sfc-gh-aalam and removed request for a team April 18, 2023 23:03
@sfc-gh-sfan sfc-gh-sfan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Apr 18, 2023
@sfc-gh-sfan sfc-gh-sfan changed the title Fix flaky test for WhenNotMatchedClause.insert Fix flaky test for table.py Apr 18, 2023
@sfc-gh-sfan sfc-gh-sfan changed the title Fix flaky test for table.py SNOW-797214 Fix flaky test for table.py Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #793 (3793e09) into main (0d2c041) will not change coverage.
The diff coverage is n/a.

❗ Current head 3793e09 differs from pull request most recent head a753026. Consider uploading reports for the commit a753026 to get more accurate results

@@           Coverage Diff           @@
##             main     #793   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files          49       49           
  Lines        8350     8350           
  Branches     1418     1418           
=======================================
  Hits         8190     8190           
  Misses         92       92           
  Partials       68       68           
Impacted Files Coverage Δ
src/snowflake/snowpark/table.py 98.59% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-sfan sfc-gh-sfan merged commit c0ba6e6 into main Apr 19, 2023
@sfc-gh-sfan sfc-gh-sfan deleted the shixuan_test_fix branch April 19, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants