Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding error with partial buys #382

Closed
1 task done
ZepsiZola opened this issue Jan 4, 2023 · 1 comment
Closed
1 task done

Rounding error with partial buys #382

ZepsiZola opened this issue Jan 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ZepsiZola
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Type of bug

Other unexpected behaviour

Environment

- Server Version: 1.19.3
- Shop Version: 1.8.4.1

Server startup log

https://paste.gg/p/anonymous/be5fc035d3354c2d80052e2219d1dad6

Shop config files

https://gist.github.com/ZepsiZola/0da7824a843609a9e520283a0ef722d1

Error log (if applicable)

No Error Log

Bug description

It's basically explained in this discord message.

image

Steps to reproduce

  1. Create a shop that sells 128 sand for 1 diamond
  2. Put only 64 sand in the chest
  3. Have at least 1 diamond in your inventory
  4. Buy sand from ShopChest
  5. It gives you 64 sand and takes your diamond
  6. There is no more sand in the chest

Expected behaviour

It should tell you that there is not enough stock in the chest to buy the sand.

Actual behaviour

  1. Create a shop that sells 128 sand for 1 diamond
  2. Put only 64 sand in the chest
  3. Have at least 1 diamond in your inventory
  4. Buy sand from ShopChest
  5. It gives you 64 sand and takes your diamond
  6. There is no more sand in the chest

Other information

No response

@ZepsiZola ZepsiZola added the bug Something isn't working label Jan 4, 2023
@snowgears snowgears changed the title [BUG] Your Title Here Rounding error with partial buys Jan 5, 2023
@snowgears
Copy link
Owner

Duplicate of #380

@snowgears snowgears marked this as a duplicate of #380 Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants