Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this work with code mirror editor? #15

Open
linonetwo opened this issue May 30, 2020 · 8 comments
Open

Does this work with code mirror editor? #15

linonetwo opened this issue May 30, 2020 · 8 comments

Comments

@linonetwo
Copy link

linonetwo commented May 30, 2020

It seems not working on my side.

I'm in 5.1.22

@linonetwo
Copy link
Author

I see...

in $:/ControlPanel -> Advanced -> Editor Type -> text/vnd.tiddlywiki you must click it, and change the content of poped tiddler from codemirror to comptext.

@snowgoon88
Copy link
Owner

Yes, sorry, but in fact this completion works only with basic/simple editor. In fact, I recreate the editor and add the completion/popup addon to it. I do not know codemirror to see if a version with completion could be possible.
I reopen to remind me to have look. One day...

@snowgoon88 snowgoon88 reopened this May 30, 2020
@atlas-comstock
Copy link

@snowgoon88 Hi, can you check this again? I really want your plugin works with CodeMirror, thanks.
Your plugin is sooo good, thanks for your work.

@snowgoon88
Copy link
Owner

Hello,
There are 2 BIG difficulties I see

  1. how to integrate the completion capability to the code mirror editor of a Tiddler. It might be that the work of saqimtiaz could help, but I would have to explore and check. A bit time consuming.

  2. more importantly. What kind of completion would you need. If it not linked to the title of another Tiddler, my module will not be easy to adapt. DO NOT expect me to make a syntaxic or lexical analysis of the javascript inside tiddler to offer completion of variables or function or...

So, before i invest some time in this, I would like you to precise what you expect of the plugin working "in code mirror".

Alain

@saqimtiaz
Copy link
Collaborator

Note that there are working solutions for title autocompletion in code mirror.

I posted a quick proof of concept last year. There is a code mirror plus add-on that does something similar: https://groups.google.com/g/tiddlywiki/c/_61Wvbkph9w/m/jVvOAUFvBwAJ

The core editor has a button for inserting links to tiddlers, which as of 5.1.23 has complete keyboard support and is triggered by ctrl+L

I don't think that extending this plugin to work with CodeMirror makes sense or is needed.

@atlas-comstock
Copy link

@snowgoon88 @saqimtiaz

Thanks for the quick reply.

I like using TW5-extendedit to insert internal links ([[some topic]]), however, the complex type file editor is so simple/plain.
So, I want to use CodeMirror with the function that TW5-extendedit can provide.

@saqimtiaz I had tried the auto complete of TW5-CodeMirror-Plus, it is so simple, does not support other TW title complement.

@saqimtiaz
Copy link
Collaborator

It is a significantly less work and a more logical approach to ask to extend the existing CodeMirror autocomplete.

@atlas-comstock
Copy link

@saqimtiaz Indeed. Then let me close this issue, thank you guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants