Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Show average damage **per cast** #33

Closed
DSchab opened this issue Sep 19, 2023 · 4 comments
Closed

Feature Request: Show average damage **per cast** #33

DSchab opened this issue Sep 19, 2023 · 4 comments

Comments

@DSchab
Copy link

DSchab commented Sep 19, 2023

I believe this would be an incredibly useful statistic for some classes that have multiple damage instances in their skill casts.
Arcana's red skills and Wardancer's Energy Combustion comes to mind, but also many others like Pistoleer Desperado or Machinist skills.

It would give the user a much better idea of how much their skill casts are doing on average.

I hope this isn't too difficult to implement as the log can already differentiate by casts per minute, for example...

@snoww
Copy link
Owner

snoww commented Sep 19, 2023

this isn't really possible to accomplish due to how the game's damage packet works, each damage tick and be in several damage packets. also cancelled casts also send a cast packet, e.g. if you cancel sorc doomsday while casting, it will increment the cast count, thus making the avg dmg per cast meaningless. the best alternative is to manually estimate how many hits per cast and math it out.

@DSchab
Copy link
Author

DSchab commented Sep 20, 2023

Would it be possible to for example graph the distribution of each skill's damage as a density plot on mouse-over? That would provide a lot more info than a simple average.

@ERoels23
Copy link

Even if cancelled casts throws off the number a bit, just having a column which calculates total_dmg/total_casts would be really nice to look at, it's the most useful stat as a dps. That statistic is the only reason I haven't completely swapped over from loa-details yet.

@snoww
Copy link
Owner

snoww commented Sep 23, 2023

i will add this next patch

@DSchab DSchab closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants