-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Mono* instances for GHC.Generics types and Data.Proxy. #175
Conversation
Thanks! Please add:
|
@snoyberg I've added the request infrastructure updates. |
mono-traversable/ChangeLog.md
Outdated
@@ -1,3 +1,8 @@ | |||
## 1.0.10.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to 1.0.11.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the version bounds appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only in the package.yaml file, not in the ChangeLog or the @since
comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused as to what you mean. I updated the haddock annotations and the Changlog.md
. Is the current haddock annotations and Changelog.md
comment what you were looking for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I was commenting that in the version I reviewed, the Haddocks and ChangeLog both still said 1.0.10.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I understand what you mean now. I have updated the code and squashed the commits together.
7f58df1
to
2594a32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The
Data.MonoTraversable
module is missing theMono*
instances for the relevant types from theGHC.Generics
andData.Proxy
modules. It would be convenient to use these in a function which accepts aMonoTraversable
input. Since the all the types for which instances were added have been included inbase
for the last several versions, this pull request should be a pretty simple and safe addition.