Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Mono* instances for GHC.Generics types and Data.Proxy. #175

Merged
merged 1 commit into from
Feb 2, 2019

Conversation

recursion-ninja
Copy link
Contributor

The Data.MonoTraversable module is missing the Mono* instances for the relevant types from the GHC.Generics and Data.Proxy modules. It would be convenient to use these in a function which accepts a MonoTraversable input. Since the all the types for which instances were added have been included in base for the last several versions, this pull request should be a pretty simple and safe addition.

@snoyberg
Copy link
Owner

Thanks! Please add:

  • A minor version bump in the package.yaml (to version 1.0.11.0)
  • A comment to the ChangeLog
  • A @since Haddock comment on each new instance

@recursion-ninja
Copy link
Contributor Author

@snoyberg I've added the request infrastructure updates.

@@ -1,3 +1,8 @@
## 1.0.10.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to 1.0.11.0

Copy link
Contributor Author

@recursion-ninja recursion-ninja Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the version bounds appropriately.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only in the package.yaml file, not in the ChangeLog or the @since comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused as to what you mean. I updated the haddock annotations and the Changlog.md. Is the current haddock annotations and Changelog.md comment what you were looking for?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I was commenting that in the version I reviewed, the Haddocks and ChangeLog both still said 1.0.10.1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I understand what you mean now. I have updated the code and squashed the commits together.

Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit df42d87 into snoyberg:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants