Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 2: API #2

Merged
merged 8 commits into from Jun 17, 2022
Merged

Milestone 2: API #2

merged 8 commits into from Jun 17, 2022

Conversation

sntakirutimana72
Copy link
Owner

Project requirements

  • Create a new game with the name of your choice by using the API.
  • Implement the "Refresh" button (receiving data from the API and parsing the JSON).
  • Implement the form "Submit" button (sending data to the API).
  • Use async and await JavaScript features to consume the API.
  • No styling is required.

Copy link

@smunozmo smunozmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sntakirutimana72, 👋

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request ❌

  • You have submitted a Pull Request that is not running the linters tests because of a merge conflict, please solve the merge conflict and submit it again for review.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

✅ Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

⚠️ Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Copy link

@smunozmo smunozmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sntakirutimana72, 👋

Highlights 👏

  • Very cool animation! 😎
  • API is working properly, nice job!
  • Great work using the right GitHub Flow.
  • Your README looks professional, well done!
  • Commits are descriptive, good work.
  • Linters are working properly, great job!

Your project is complete! There is nothing else to say other than... it's time to merge it! 🚀
Very nice work, congratulations! 🎉

APPROVED! 💯 💯 💯

Cheers and Happy coding! 🤓

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

✅ Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@sntakirutimana72 sntakirutimana72 merged commit 691fa01 into develop Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants