Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3: Add style markup #3

Merged
merged 2 commits into from Jun 17, 2022
Merged

Milestone 3: Add style markup #3

merged 2 commits into from Jun 17, 2022

Conversation

sntakirutimana72
Copy link
Owner

Project requirements

  • Now you should improve the look and feel of the application, adding the styles of your choice.
  • Please keep the general layout of the wireframe, this is the only mandatory requirement.
  • You can use plain CSS or any CSS framework, it's up to you.

Copy link

@arslanbisharat arslanbisharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sntakirutimana72 ,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • The Pull Request has a proper title and description. ✔️
  • You have added a descriptive Readme file. Good Job. ✔️
  • There is no linter error is present. ✔️
  • Project has met all the technical aspects you needed for this project. Keep rocking! ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@sntakirutimana72 sntakirutimana72 merged commit 15fd71f into develop Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants