JS-Best-Practive

[sntakirutimana72]

Feedback

• Some of the functions can be renamed to reflect the exact nature of their roles instead of create(), it could be createNewTask(). For instance, the code snippet below can be improved in the way mentioned above

  export const remove = (obj) => {
    let index = 0;

• Method chaining where classes are concerned should be considered. For instance,

  class TasksManager {    
    set tasks(tasks) {
      this.allTasks = tasks;
    }
  
    assign(task) {
      this.allTasks.push(task);
    }

• In the below code snippet, the function could've been separated into 2 functions to avoid the use of flags

  const $select = (selector, all, parentTree) => {
    parentTree = document.body;
  
    if (!parentTree) parentTree = document.body;
  
    if (all === true) return parentTree.querySelectorAll(selector);
  
    return parentTree.querySelector(selector);
  };