Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: adds mix format configuration and formats code. #76

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Feature: adds mix format configuration and formats code. #76

merged 1 commit into from
Jul 26, 2019

Conversation

achedeuzot
Copy link
Owner

@achedeuzot achedeuzot commented Jul 18, 2019

This PR follows the previous one (PR #75). It's best to merge them in order.

It contains format & dialyzer updates.

Copy link

@hez hez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great work, elixirs formatter is great at cleaning code up and removing any ambiguity about what spacing to use! Keep up the good work, very much appreciated.

@achedeuzot
Copy link
Owner Author

Gentle reminder about this PR :)

@sntran
Copy link
Collaborator

sntran commented Jul 25, 2019

@achedeuzot , did this PR got mixed up with the other PR? I see changes for dependencies in there. I think I messed up the order.

@achedeuzot
Copy link
Owner Author

strange indeed, I'll fix it asap.

@achedeuzot
Copy link
Owner Author

Ok, my bad, the mix.lock that was merged in the previous PR #75 wasn't up to date. I switched and rebased branches so many times I got confused. The easiest way to fix this is to simply merge this branch. Otherwise I can try doing a small mix.lock separate branch, then rebase this one on top and hope it won't conflict too much :P

@sntran
Copy link
Collaborator

sntran commented Jul 25, 2019

How about I adding you as collaborator 😉 so you can sort it out easier?

@achedeuzot
Copy link
Owner Author

Yep :) That would be amazing!

@achedeuzot achedeuzot merged commit c9ca8ad into achedeuzot:master Jul 26, 2019
@achedeuzot achedeuzot deleted the feature/code-formatter branch July 26, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants