Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ace IM doesn't support the longer 16-character passwords introduced to ICQ in 2016 #5

Closed
GrandAdmiralThrawn opened this issue Aug 17, 2017 · 5 comments

Comments

@GrandAdmiralThrawn
Copy link

GrandAdmiralThrawn commented Aug 17, 2017

I believe it's just some truncates that would need to be updated from 8 to 16 symbols/characters.

Ace IM ICQ Module/src/aceim/protocol/snuk182/icq/inner/ICQServiceInternal.java line 668:

// ICQ does not support passwords longer than 8 symbols                         
if (pw != null && pw.length() > 8) {
  pw = pw.substring(0, 8);
}

and...

Ace IM ICQ Module/src/aceim/protocol/snuk182/icq/inner/dataprocessing/AuthenticationProcessor.java line 133:

// they don't support passwords longer than 8 symbols (facepalm)
if (pw.length > 8) {
  ln = 8;
} else {
  ln = pw.length;
}
@snuk182
Copy link
Owner

snuk182 commented Aug 21, 2017

Thanks a lot for the notification! Will check this as soon as possible.

@GrandAdmiralThrawn
Copy link
Author

Thanks a lot!

I'd like to use your client because it seems to be the only one (?) that doesn't leak my credentials to external "proxy" servers to login to ICQ from there.

But I need long password support. :)

@snuk182
Copy link
Owner

snuk182 commented Aug 22, 2017

I need your help with testing, as I do not use ICQ for ages. Could you please remove .zip extension from an attachment and install and test it? It is already signed with a release certificate, so should not conflict with the previous installation and, if succeeded, will be uploaded to Play at once.
PS It worked for me, I was even able to recall my ICQ password ^^ :)
icq.apk.zip

@GrandAdmiralThrawn
Copy link
Author

I just tested it with my long password, and can confirm that it's fully working! :) Thank you very much for 1.) actually fixing this and 2.) doing it so quickly as well!

@snuk182
Copy link
Owner

snuk182 commented Aug 23, 2017

5e4359c

@snuk182 snuk182 closed this as completed Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants