feat: adding commit fixes and descriptions to the rules' properties #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COD-114 Storing automatic fix examples on our DB 🗄️ Example commit fixes need to be stored in our database. ✅ Exporting the `ExampleCommitFix` interface to make it accessible to the Sarif Converter. ✅ Updating the `properties` object on `rules` instances of the Sarif Converter to be able to store them. ✅ Updating the Sarif Converter spec to test for the presence of the exemple `ExampleCommitFix`.
|
Referring to the now closed: |
j-sp4
approved these changes
Feb 24, 2021
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COD-114 Storing automatic fix examples on our DB
🗄️ Example commit fixes need to be stored in our database.
What does this PR do?
✅ Exporting the
ExampleCommitFixinterface to make it accessible to the Sarif Converter.✅ Updating the
propertiesobject onrulesinstances of the Sarif Converter to be able to store them.✅ Updating the Sarif Converter spec to test for the presence of the exemple
ExampleCommitFix.Where should the reviewer start?
RulePropertytype and its use.tests/sarif_converter.spec.tstest.How should this be manually tested?
tests/sarif_converter.spec.tstest.