You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Furthermore, the extension exposes an argument that is added to the list automatically: severity. That's not clear to the end user and could cause confusion when defined as part of arguments. Either keep the arguments as list and remove the field severity or introduce properties for each argument to be consistent.
The text was updated successfully, but these errors were encountered:
Another point is that an end user might want to extend the list of arguments later e.g. from a plugin. How do you add a new argument with the String parameter? Even if you could the end user needs to ensure that the space is added for every argument which she can get wrong easily.
need to rework the extension to use the lazy gradle API's. so this should probably be aListProperty
I think in most cases it probably won't matter that it would be a list but using a property should help ensure that people can do more advanced configuration without any extra burden on this project
Arguments are a list of Strings. From an end user's perspective it looks counter-intuitive to put together a single String for multiple arguments. See
gradle-plugin/src/main/java/io/snyk/gradle/plugin/SnykExtension.java
Line 9 in 2e08af4
vs.
Furthermore, the extension exposes an argument that is added to the list automatically:
severity
. That's not clear to the end user and could cause confusion when defined as part ofarguments
. Either keep the arguments as list and remove the fieldseverity
or introduce properties for each argument to be consistent.The text was updated successfully, but these errors were encountered: