fix: Spacing for issue descriptions with custom rules

snyk · Aug 24, 2022 · 29b2fdb · 29b2fdb
1 parent 42d4720
commit 29b2fdb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/lib/formatters/iac-output/v2/issues-list/issue.ts b/src/lib/formatters/iac-output/v2/issues-list/issue.ts
@@ -77,16 +77,18 @@ function formatProperties(
         ? result.issue.remediation[remediationKey]
         : result.issue.resolve,
     ],
-  ].filter(([, val]) => !!val) as [string, string][];
+  ];
 
   const maxPropertyNameLength = Math.max(
     ...properties.map(([key]) => key.length),
   );
 
-  return properties.map(
-    ([key, value]) =>
-      `${key}: ${' '.repeat(maxPropertyNameLength - key.length)}${value}`,
-  );
+  return properties
+    .filter(([, val]) => !!val)
+    .map(
+      ([key, value]) =>
+        `${key}: ${' '.repeat(maxPropertyNameLength - key.length)}${value}`,
+    );
 }
 
 function isValidLineNumber(lineNumber: number | undefined): boolean {

diff --git a/test/jest/acceptance/iac/output-formats/text.spec.ts b/test/jest/acceptance/iac/output-formats/text.spec.ts
@@ -275,7 +275,7 @@ Target file:       ${dirPath}/`);
           `snyk iac test ${filePath} --rules=./iac/custom-rules/custom.tar.gz`,
         );
 
-        expect(stdout).toContain(`Rule: custom rule CUSTOM-1`);
+        expect(stdout).toContain(`Rule:    custom rule CUSTOM-1`);
       });
     });
   });