feat: improve snyk fix output

- bump the @snyk/fix version to one that includes full
targetFile paths in all output
- swap out the spinner icon & fix a spinner not clearing when
multuple paths tested

package.json

@@ -75,7 +75,7 @@
     "@snyk/cloud-config-parser": "^1.9.2",
     "@snyk/code-client": "3.4.0",
     "@snyk/dep-graph": "^1.27.1",
-    "@snyk/fix": "1.526.0",
+    "@snyk/fix": "1.539.0",
     "@snyk/gemfile": "1.2.0",
     "@snyk/graphlib": "^2.1.9-patch.3",
     "@snyk/inquirer": "^7.3.3-patch",

packages/snyk-fix/src/plugins/python/index.ts

@@ -63,10 +63,6 @@ export async function pythonFix(
         results.failed.push(
           ...projectsToFix.map((p) => ({ original: p, error: e })),
         );
-        spinner.stopAndPersist({
-          text: processingMessage,
-          symbol: chalk.green('✔'),
-        });
       }
       spinner.stopAndPersist({
         text: processingMessage,

src/cli/commands/fix/index.ts

@@ -17,6 +17,7 @@ import { setDefaultTestOptions } from '../test/set-default-test-options';
 import { validateFixCommandIsSupported } from './validate-fix-command-is-supported';
 import { Options, TestOptions } from '../../../lib/types';
 import { getDisplayPath } from './get-display-path';
+import chalk from 'chalk';
 
 const debug = Debug('snyk-fix');
 const snykFixFeatureFlag = 'cliSnykFix';
@@ -71,9 +72,12 @@ async function runSnykTestLegacy(
 
   for (const path of paths) {
     let displayPath = path;
+    const spinnerMessage = `Running \`snyk test\` for ${displayPath}`;
+
     try {
       displayPath = getDisplayPath(path);
-      stdOutSpinner.info(`Running \`snyk test\` for ${displayPath}`);
+      stdOutSpinner.text = spinnerMessage;
+      stdOutSpinner.render();
       // Create a copy of the options so a specific test can
       // modify them i.e. add `options.file` etc. We'll need
       // these options later.
@@ -96,10 +100,23 @@ async function runSnykTestLegacy(
       );
       const newRes = convertLegacyTestResultToFixEntities(testResults, path);
       results.push(...newRes);
+      stdOutSpinner.stopAndPersist({
+        text: spinnerMessage,
+        symbol: '\n►',
+      });
     } catch (error) {
       const testError = formatTestError(error);
-      const userMessage = `Test for ${displayPath} failed with error: ${testError.message}.\nRun \`snyk test ${displayPath} -d\` for more information.`;
-      stdErrSpinner.fail(userMessage);
+      const userMessage =
+        chalk.red(`Failed! ${testError.message}.`) +
+        `\n  Tip: run \`snyk test ${displayPath} -d\` for more information.`;
+      stdOutSpinner.stopAndPersist({
+        text: spinnerMessage,
+        symbol: '\n►',
+      });
+      stdErrSpinner.stopAndPersist({
+        text: userMessage,
+        symbol: chalk.red(' '),
+      });
       debug(userMessage);
     }
   }

src/cli/commands/fix/validate-fix-command-is-supported.ts

@@ -28,12 +28,13 @@ export async function validateFixCommandIsSupported(
     options.org,
   );
 
+  debug('Feature flag check returned: ', snykFixSupported);
+
   if (snykFixSupported.code === 401 || snykFixSupported.code === 403) {
     throw AuthFailedError(snykFixSupported.error, snykFixSupported.code);
   }
 
   if (!snykFixSupported.ok) {
-    debug('Feature flag check returned: ', snykFixSupported);
     throw new CommandNotSupportedError('snyk fix', options.org || undefined);
   }