Skip to content

Commit

Permalink
feat: container Go binary scan
Browse files Browse the repository at this point in the history 
Bumps the version of the docker-plugin to support trimmed, stripped and
Cgo binaries.

See [snyk-docker-plugin #447](snyk/snyk-docker-plugin#447)
for more info.
  • Loading branch information
@tommyknows
tommyknows committed Sep 6, 2022
1 parent b46e07b commit 47af5ca
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"semver": "^6.0.0",
"snyk-config": "4.0.0",
"snyk-cpp-plugin": "2.20.0",
"snyk-docker-plugin": "^5.3.2",
"snyk-docker-plugin": "^5.4.0",
"snyk-go-plugin": "1.19.2",
"snyk-gradle-plugin": "3.22.2",
"snyk-module": "3.1.0",
Expand Down

3 comments on commit 47af5ca

@aneqinun
Copy link

@aneqinun aneqinun commented on 47af5ca Sep 14, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tommyknows, is there a way to disable or ignore the Go binary scan when doing a snyk container test?

When I am running a snyk container test, I am getting a 'no pcln table found in Go binary' error when scanning containers installed with the 'docker-ce'cli' or the 'mongodb-database-tools' apt packages. I want to keep the snyk scan of course but these packages are mandatory for my use-case, so I need to keep them whilst also having my pipeline succeed.

@tommyknows
Copy link
Contributor Author

@tommyknows tommyknows commented on 47af5ca Sep 14, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aneqinun, sorry for breaking your use case. That there are Go binaries without PCLN tables was something we were not aware of until yesterday, when we noticed this breaking as well. We have just pushed a change that will skip Go binaries without a PCLN table, which means you can simply update your CLI to 1.1005.0 and it should work again.

@aneqinun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tommyknows, no worries. Thanks very much for the rapid response, all of my issues now seem to be resolved with the new v1.1005.0 as you said.
Much appreciated!

Please sign in to comment.