fix: make IaC issue resource file optional (#4763)

snyk · Aug 1, 2023 · 76109c7 · 76109c7
1 parent 560e1ab
commit 76109c7
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/src/lib/formatters/iac-output/text/issues-list/index.ts b/src/lib/formatters/iac-output/text/issues-list/index.ts
@@ -41,8 +41,8 @@ export function getIacDisplayedIssues(
       const issuesOutput = severityResults
         .sort(
           (severityResult1, severityResult2) =>
-            severityResult1.targetFile.localeCompare(
-              severityResult2.targetFile,
+            severityResult1.targetFile?.localeCompare(
+              severityResult2.targetFile as string,
             ) ||
             severityResult1.issue.id.localeCompare(severityResult2.issue.id),
         )

diff --git a/src/lib/formatters/iac-output/text/types.ts b/src/lib/formatters/iac-output/text/types.ts
@@ -16,8 +16,8 @@ export type FormattedOutputResultsBySeverity = {
 
 export type FormattedOutputResult = {
   issue: Issue;
-  targetFile: string;
   projectType: IacProjectType | State.InputTypeEnum;
+  targetFile?: string;
 };
 
 export interface IacTestCounts {

diff --git a/src/lib/iac/test/v2/analytics/iac-type.ts b/src/lib/iac/test/v2/analytics/iac-type.ts
@@ -75,7 +75,9 @@ function getFilesCountByPackageManager(
         acc[packageManager] = new Set();
       }
 
-      acc[packageManager].add(resource.file);
+      if (resource.file) {
+        acc[packageManager].add(resource.file);
+      }
 
       return acc;
     }, {} as { [packageManager in PackageManager]: Set<string> }),

diff --git a/src/lib/iac/test/v2/scan/results.ts b/src/lib/iac/test/v2/scan/results.ts
@@ -112,10 +112,10 @@ export interface Rule {
 export interface Resource {
   id: string;
   type: string;
-  path?: any[];
-  formattedPath: string;
-  file: string;
   kind: ResourceKind;
+  formattedPath: string;
+  path?: any[];
+  file?: string;
   line?: number;
   column?: number;
 }