Skip to content

Commit

Permalink
feat: remove vulndb ff for unmanaged
Browse files Browse the repository at this point in the history
- remove the vulndb feature flag for the unmanaged flows
- bump the cpp plugin version
  • Loading branch information
danlucian committed Feb 24, 2022
1 parent f3544a8 commit c251a7d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 20 deletions.
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"rimraf": "^2.6.3",
"semver": "^6.0.0",
"snyk-config": "4.0.0",
"snyk-cpp-plugin": "^2.16.5",
"snyk-cpp-plugin": "2.16.7",
"snyk-docker-plugin": "^4.34.5",
"snyk-go-plugin": "1.18.0",
"snyk-gradle-plugin": "3.17.0",
Expand Down
12 changes: 1 addition & 11 deletions src/lib/ecosystems/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { TestDependenciesResponse } from '../snyk-test/legacy';
import { assembleQueryString } from '../snyk-test/common';
import { getAuthHeader } from '../api-token';
import { resolveAndTestFacts } from './resolve-test-facts';
import { hasFeatureFlag } from '../feature-flags';
import { isUnmanagedEcosystem } from './common';

export async function testEcosystem(
Expand Down Expand Up @@ -54,20 +53,11 @@ export async function testEcosystem(
const emptyResults: ScanResult[] = [];
const scanResults = emptyResults.concat(...Object.values(scanResultsByPath));

const enhancedOptions = { ...options };

if (isUnmanagedEcosystem(ecosystem)) {
enhancedOptions.supportUnmanagedVulnDB = await hasFeatureFlag(
'snykUnmanagedVulnDB',
options,
);
}

const readableResult = await plugin.display(
scanResults,
testResults,
errors,
enhancedOptions,
options,
);

return TestCommandResult.createHumanReadableTestCommandResult(
Expand Down
1 change: 0 additions & 1 deletion src/lib/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ export interface Options {
tags?: string;
'target-reference'?: string;
'exclude-base-image-vulns'?: boolean;
supportUnmanagedVulnDB?: boolean;
'no-markdown'?: boolean;
'max-depth'?: number;
}
Expand Down

0 comments on commit c251a7d

Please sign in to comment.