Merge pull request #931 from snyk/chore/refactor-manage-url

chore: refactor manage url into a function

src/cli/commands/monitor/formatters/format-monitor-response.ts

@@ -1,15 +1,18 @@
 import * as _ from 'lodash';
 import chalk from 'chalk';
+import * as url from 'url';
+
 import { MonitorResult } from '../../../../lib/types';
+import * as config from '../../../../lib/config';
 
 export function formatMonitorOutput(
   packageManager,
   res: MonitorResult,
-  manageUrl,
   options,
   projectName?: string,
   foundProjectCount?: number,
 ): string {
+  const manageUrl = buildManageUrl(res.id, res.org);
   const advertiseGradleSubProjectsCount =
     packageManager === 'gradle' && !options['gradle-sub-project'];
 
@@ -61,3 +64,17 @@ export function formatMonitorOutput(
       )
     : strOutput;
 }
+
+function buildManageUrl(resId: string, org?: string): string {
+  const endpoint = url.parse(config.API);
+  let leader = '';
+  if (org) {
+    leader = '/org/' + org;
+  }
+  endpoint.pathname = leader + '/manage';
+  const manageUrl = url.format(endpoint);
+
+  // TODO: what was this meant to do?
+  endpoint.pathname = leader + '/monitor/' + resId;
+  return manageUrl;
+}

src/cli/commands/monitor/index.ts

@@ -169,22 +169,12 @@ async function monitor(...args0: MethodArgs): Promise<any> {
         await spinner.clear(postingMonitorSpinnerLabel)(res);
 
         res.path = path;
-        const endpoint = url.parse(config.API);
-        let leader = '';
-        if (res.org) {
-          leader = '/org/' + res.org;
-        }
-        endpoint.pathname = leader + '/manage';
-        const manageUrl = url.format(endpoint);
-
-        endpoint.pathname = leader + '/monitor/' + res.id;
         const projectName = pluginApi.isMultiResult(inspectResult)
           ? projectDeps.package.name
           : undefined;
         const monOutput = formatMonitorOutput(
           packageManager,
           res,
-          manageUrl,
           options,
           projectName,
           foundProjectCount,