chore: Update custom bundle.tar.gz in fixtures

Co-authored-by: Teodora Sandu <teodora.sandu@snyk.io>
snyk · Jan 4, 2022 · ce9fbe4 · ce9fbe4
1 parent 4cbc544
commit ce9fbe4
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 23 deletions.
diff --git a/test/fixtures/iac/custom-rules/custom.tar.gz b/test/fixtures/iac/custom-rules/custom.tar.gz
diff --git a/test/jest/acceptance/iac/custom-rules.spec.ts b/test/jest/acceptance/iac/custom-rules.spec.ts
@@ -29,7 +29,7 @@ describe('iac test --rules', () => {
     expect(stdout).toContain('Testing ./iac/terraform/sg_open_ssh.tf');
     expect(stdout).toContain('Infrastructure as code issues:');
     expect(stdout).toContain('Missing tags');
-    expect(stdout).toContain('CUSTOM-123');
+    expect(stdout).toContain('CUSTOM-1');
     expect(stdout).toContain(
       'introduced by input > resource > aws_security_group[allow_ssh] > tags',
     );

diff --git a/test/jest/unit/iac-unit-tests/file-scanner.spec.ts b/test/jest/unit/iac-unit-tests/file-scanner.spec.ts
@@ -1,11 +1,13 @@
-import * as mockFs from 'mock-fs';
 import * as path from 'path';
 import {
   scanFiles,
   clearPolicyEngineCache,
 } from '../../../../src/cli/commands/test/iac-local-execution/file-scanner';
 import { LOCAL_POLICY_ENGINE_DIR } from '../../../../src/cli/commands/test/iac-local-execution/local-cache';
-import { IacFileParsed } from '../../../../src/cli/commands/test/iac-local-execution/types';
+import {
+  EngineType,
+  IacFileParsed,
+} from '../../../../src/cli/commands/test/iac-local-execution/types';
 
 import {
   paresdKubernetesFileStub,
@@ -15,6 +17,7 @@ import {
   expectedViolatedPoliciesForTerraform,
   expectedViolatedPoliciesForArm,
 } from './file-scanner.fixtures';
+import * as localCacheModule from '../../../../src/cli/commands/test/iac-local-execution/local-cache';
 
 describe('scanFiles', () => {
   const parsedFiles: Array<IacFileParsed> = [
@@ -24,23 +27,48 @@ describe('scanFiles', () => {
   ];
 
   afterEach(() => {
-    mockFs.restore();
     clearPolicyEngineCache();
   });
 
   describe('with parsed files', () => {
     it('returns the expected violated policies', async () => {
-      mockFs({
-        [path.resolve(
-          __dirname,
-          path.join('../../../..', LOCAL_POLICY_ENGINE_DIR),
-        )]: mockFs.load(
-          path.resolve(
-            __dirname,
-            path.join('../../../smoke', LOCAL_POLICY_ENGINE_DIR),
-          ),
-        ),
-      });
+      const policyEngineCoreDataPath = path.resolve(
+        __dirname,
+        path.join('../../../smoke', LOCAL_POLICY_ENGINE_DIR),
+      );
+      const policyEngineMetaDataPath = path.resolve(
+        __dirname,
+        path.join('../../../smoke', LOCAL_POLICY_ENGINE_DIR),
+      );
+
+      const spy = jest
+        .spyOn(localCacheModule, 'getLocalCachePath')
+        .mockImplementation((engineType: EngineType) => {
+          switch (engineType) {
+            case EngineType.Kubernetes:
+              return [
+                `${policyEngineCoreDataPath}/k8s_policy.wasm`,
+                `${policyEngineMetaDataPath}/k8s_data.json`,
+              ];
+            case EngineType.Terraform:
+              return [
+                `${policyEngineCoreDataPath}/tf_policy.wasm`,
+                `${policyEngineMetaDataPath}/tf_data.json`,
+              ];
+            case EngineType.CloudFormation:
+              return [
+                `${policyEngineCoreDataPath}/cloudformation_policy.wasm`,
+                `${policyEngineMetaDataPath}/cloudformation_data.json`,
+              ];
+            case EngineType.ARM:
+              return [
+                `${policyEngineCoreDataPath}/arm_policy.wasm`,
+                `${policyEngineMetaDataPath}/arm_data.json`,
+              ];
+            default:
+              return [];
+          }
+        });
 
       const scanResults = await scanFiles(parsedFiles);
       expect(scanResults[0].violatedPolicies).toEqual(
@@ -52,20 +80,13 @@ describe('scanFiles', () => {
       expect(scanResults[2].violatedPolicies).toEqual(
         expectedViolatedPoliciesForArm,
       );
+      spy.mockReset();
     });
-
     // TODO: Extract policy engine & the cache mechanism, test them separately.
   });
 
   describe('missing policy engine wasm files', () => {
     it('throws an error', async () => {
-      mockFs({
-        [path.resolve(
-          __dirname,
-          path.join('../../../..', LOCAL_POLICY_ENGINE_DIR),
-        )]: {},
-      });
-
       await expect(scanFiles(parsedFiles)).rejects.toThrow();
     });
   });