Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert to using console.error for debug messages #4478

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix: revert to using console.error for debug messages #4478

merged 1 commit into from
Mar 21, 2023

Conversation

j-luong
Copy link
Contributor

@j-luong j-luong commented Mar 21, 2023

What does this PR do?

Uses stdErr for logging so it does not conflict with the CLI using stdOut

@j-luong j-luong requested review from a team as code owners March 21, 2023 14:45
@github-actions
Copy link
Contributor

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • ts-binary-wrapper/src/common.ts

Generated by 🚫 dangerJS against fe95660

@j-luong j-luong merged commit f28ceb1 into master Mar 21, 2023
@j-luong j-luong deleted the fix/stdOutBug branch March 21, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSchafer PeterSchafer PeterSchafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@j-luong @PeterSchafer