fix: build image #4727
Merged
fix: build image #4727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would rather use the installed version, instead of installing it at runtime - that's the whole point of a build image, to deliver the tools, not having them installed from externally :). |
PeterSchafer
approved these changes
Jun 28, 2023
bastiandoetsch
force-pushed
the
chore/update-build-image
branch
from
0db390a
to
c17cb11
Compare
PeterSchafer
approved these changes
Jun 30, 2023
j-luong
pushed a commit
that referenced
this pull request
Jul 11, 2023
* fix: build image for cli * chore: remove osssigntool (not needed on native builds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions