feat: add acceptance test for running language server integrated in CLI [HEAD-687] #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiandoetsch
changed the title
bastiandoetsch
force-pushed
the
chore/HEAD-687_ls_acc_tests
branch
from
72cd2da
to
11e991b
Compare
Co-authored-by: Peter Schäfer <peter.schafer@snyk.io>
bastiandoetsch
force-pushed
the
chore/HEAD-687_ls_acc_tests
branch
from
11e991b
to
eaaa70a
Compare
(it was early in the morning)
PeterSchafer
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This tests the successful embedding of language server as extension into the CLI binary. It is not a complete check, but a sanity check using Snyk Open Source scans and their reported diagnostics.
Tests:
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions