feat: make organization ID generally available [HEAD-855] #4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
force-pushed
the
feat/HEAD-855_supply_org_id
branch
from
da05274
to
1f7d67c
Compare
PeterSchafer
force-pushed
the
feat/HEAD-855_supply_org_id
branch
from
1f7d67c
to
9290bc3
Compare
PeterSchafer
changed the title
PeterSchafer
force-pushed
the
feat/HEAD-855_supply_org_id
branch
from
24615a2
to
c510302
Compare
| var p WrapperProxy | ||
| p.DebugLogger = debugLogger | ||
| p.cliVersion = cliVersion | ||
| p.addHeaderFunc = func(request *http.Request) error { return nil } | ||
|
|
||
| cacheDirectory := config.GetString(configuration.CACHE_PATH) |
There was a problem hiding this comment.
praise: nice to include this here
| func NewCLIv2(cacheDirectory string, debugLogger *log.Logger) (*CLI, error) { | ||
| func NewCLIv2(config configuration.Configuration, debugLogger *log.Logger) (*CLI, error) { | ||
|
|
||
| cacheDirectory := config.GetString(configuration.CACHE_PATH) |
There was a problem hiding this comment.
question: should we ensure that the directory is writeable?
There was a problem hiding this comment.
Good idea, I think this should be done more centrally. In general the default cache path is checked for being writeable.
bastiandoetsch
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the Legacy CLI, introduce an additional config value that will always hold the orgId provided by the Extensible CLI.
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions