Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add condition to preserve project-name with gradle monitor #4906

Merged
merged 1 commit into from Oct 30, 2023
Merged

fix: add condition to preserve project-name with gradle monitor #4906

merged 1 commit into from Oct 30, 2023

Conversation

danielroymoore
Copy link
Contributor

@danielroymoore danielroymoore commented Oct 13, 2023 •
edited

Following on from #4865 this change tightens the method to explicitly check if allProjects is set and acts accordingly, either by making use of project name or falling back to the projectName flag.

@snyk snyk deleted a comment from github-actions bot Oct 13, 2023
@danielroymoore danielroymoore force-pushed the fix/gradle-project-names branch 3 times, most recently from b504092 to 54d2c32 Compare October 20, 2023 15:06
@danielroymoore danielroymoore force-pushed the fix/gradle-project-names branch 2 times, most recently from 38a6d31 to e42517b Compare October 20, 2023 15:59
@DOlufemi DOlufemi marked this pull request as ready for review October 24, 2023 08:51
@DOlufemi DOlufemi requested review from a team as code owners October 24, 2023 08:51
darscan
darscan previously requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@darscan darscan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase instead of merging mainline back into your feature branch (which creates a messy history).

Also, please add or amend some tests. The previous "fix" added some tests, so just modify or add to those

@DOlufemi DOlufemi enabled auto-merge (squash) October 25, 2023 12:41
@DOlufemi DOlufemi merged commit 351c7bd into master Oct 30, 2023
12 checks passed
@DOlufemi DOlufemi deleted the fix/gradle-project-names branch October 30, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darscan darscan darscan left review comments

@DOlufemi DOlufemi DOlufemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@danielroymoore @darscan @DOlufemi