fix: allow http requests towards code local engine [NEBULA-1541]

[soniqua]

What does this PR do?

• Allows requests made towards the Snyk Code Local Engine /status endpoint to respect the protocol of the Local Engine URL set on the org/group
• Fixes conditions where a Snyk Code Local Engine installation responds on both http and https and we want to query http only
• Allows certificate trust to remain intact

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

[github-actions]

	Warnings
⚠️	You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 5adbbed

[shirlupo]

from the code seems like we already calling this function with baseURL

cli/src/lib/plugins/sast/analysis.ts

Line 72 in b2682f4

await logLocalCodeEngineVersion(baseURL);

my assumption is we do not,
can you maybe change this as well?

I am a bit confused what is happening here if no broker in the picture? are we just failing this as Snyk Code Local Engine health is not ok ?

[shirlupo]

Approved with some sug and a question

[neonnoon]

I am not sure I understand what you mean with this @shirlupo:

from the code seems like we already calling this function with baseURL
my assumption is we do not,

Do you mean, why do we set a default parameter (='')?
That is a fair question as this will clearly not work. So can localEngineUrl be undefined? In that case we'd have to properly handle it instead of defaulting to empty string.

I am a bit confused what is happening here if no broker in the picture? are we just failing this as Snyk Code Local Engine health is not ok ?

There is no broker in the picture either way. This is CLI connecting directly to local engine.
Where would you expect broker (server or client?) to be involved?

[shirlupo]

I am not sure I understand what you mean with this @shirlupo:

from the code seems like we already calling this function with baseURL
my assumption is we do not,

Do you mean, why do we set a default parameter (='')? That is a fair question as this will clearly not work. So can localEngineUrl be undefined? In that case we'd have to properly handle it instead of defaulting to empty string.

I meant the naming of the parameter 'baseUrl'

cli/src/lib/plugins/sast/analysis.ts

Line 72 in b2682f4

await logLocalCodeEngineVersion(baseURL);

from Matt and Matthew's code it seems like they parse the baseUrl so calling the parameter here baseURL is odd to me

---

I am a bit confused what is happening here if no broker in the picture? are we just failing this as Snyk Code Local Engine health is not ok ?

There is no broker in the picture either way. This is CLI connecting directly to local engine. Where would you expect broker (server or client?) to be involved?

There is a call here to get the version by calling the health check no?

[neonnoon]

I meant the naming of the parameter 'baseUrl'
from Matt and Matthew's code it seems like they parse the baseUrl so calling the parameter here baseURL is odd to me

Ok, I thin base isn't quite right (as it's the full localEngineUrl incl. /api)?
But why do you think it shouldn't be called baseUrl because it is parsed?

There is no broker in the picture either way. This is CLI connecting directly to local engine. Where would you expect broker (server or client?) to be involved?

There is a call here to get the version by calling the health check no?

Yes, directly to the local engine (via local-proxy), no broker is needed for this.

[soniqua]

Yep, the parameter fed to this function includes the /api path, so baseUrl is a misnomer in analysis.ts.

[shirlupo]

yeah I meant the naming "base" is not right, that's it not biggy :)