Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add range to snyk.scan message created by code scanner [IDE-134] #5052

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Feb 13, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

What does this PR do?

This updates the Snyk Language Server extension to the latest version. Currently, the $/snyk.scan custom message from Snyk Code is sent without a valid range. The range is specified in the structure, but just not filled. The new language server version remedies this.

Where should the reviewer start?

Have a look at commit 5c61976 of snyk-ls - it contains tests and the changed code.
snyk/snyk-ls@5c61976#diff-5fdc92093964521489fec0d3eb3f9384994e19496fc0d274e0d6a3c3086a975dR81

How should this be manually tested?

Start up VSCode and have it do a Snyk Code scan

Any background context you want to provide?

This PR is necessary to use the experimental preview feature of sourcing Snyk Code findings from Language Server in IntelliJ.

What are the relevant tickets?

IDE-134

Screenshots

Additional questions

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner February 13, 2024 12:47
@bastiandoetsch bastiandoetsch force-pushed the fix/IDE-134_update-ls-to-include-range-in-code-custom-scan-messages branch from 6e741e9 to f0ac681 Compare February 13, 2024 12:55
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) February 13, 2024 12:55
@bastiandoetsch bastiandoetsch changed the base branch from master to main February 15, 2024 11:52
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) February 15, 2024 11:52
@bastiandoetsch bastiandoetsch force-pushed the fix/IDE-134_update-ls-to-include-range-in-code-custom-scan-messages branch from 5aa38c2 to a839a41 Compare February 19, 2024 14:37
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) February 19, 2024 14:37
@bastiandoetsch bastiandoetsch force-pushed the fix/IDE-134_update-ls-to-include-range-in-code-custom-scan-messages branch from a839a41 to 5c8d3e7 Compare February 20, 2024 10:11
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) February 20, 2024 10:11
@bastiandoetsch bastiandoetsch merged commit 3692fe2 into main Feb 20, 2024
12 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/IDE-134_update-ls-to-include-range-in-code-custom-scan-messages branch February 20, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants