fix: always finish progress when auto-fixing in language server #5145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
This PR pulls in the latest language server. This ensures, progresses are ended even if errors occur. Also, behind a feature flag, some changes to prepare for global ignores are included, as they came before this commit & PR.
Risk: LOW
Where should the reviewer start?
snyk/snyk-ls@9d7d19c
snyk/snyk-ls#478
How should this be manually tested?
Any background context you want to provide?
In case of DeepCode AI fix failing, the progress.End() command was never called.
What are the relevant tickets?
IDE-134
Screenshots
Additional questions