Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

click to fix - not working on tap pkg #32

Open
remy opened this issue Apr 30, 2020 · 2 comments
Open

click to fix - not working on tap pkg #32

remy opened this issue Apr 30, 2020 · 2 comments

Comments

@remy
Copy link
Contributor

remy commented Apr 30, 2020

Screenshot 2020-04-30 at 17 09 32

Two points here:

  1. Clicking didn't do anything, I had to go away from the decoration and to the 'tap' line, hover, open menu, then select 'fix'.
  2. From there, it says there's no rememdiation available - so it can't actually be fixed.
@rajivshah3
Copy link

rajivshah3 commented Sep 23, 2020

One other issue is that "fix vuln" shows even though a vulnerability is not fixable:
image

I'm happy to make a PR to fix this, but I'm not sure what it should say instead

@MaggieFero
Copy link
Contributor

Maybe "Remediation options"? I checked a few in my own repos, and it seems to provide some additional details (but less than the page at "Learn about this vulnerability") with either

  • "Possible remediation" with version candidates (including when there's a patch meant to fix the vuln) or
  • "No remediation available."

The extension already expects people to know the term "remediation" once they click on the button, so it's not introducing any new language complexity to use it here. It would also still be shorter than the following text string, so space shouldn't be an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants