Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dustbin] Error after the mod disable #1

Closed
starfi5h opened this issue Dec 4, 2022 · 1 comment
Closed

[Dustbin] Error after the mod disable #1

starfi5h opened this issue Dec 4, 2022 · 1 comment

Comments

@starfi5h
Copy link

starfi5h commented Dec 4, 2022

Dustbin 1.1.0 DSP 0.9.27.15033
Steps to reproduce:

  1. Turn a stroage box into Dustbin
  2. Fill stroage box to full
  3. Save, disable the mod and load again
  4. Error when sorters trying to insert

error

我觉得把StorageComponent.bans设为负数, 以此来判断是否为垃圾桶不太安全
建议可以用DSPModSave另外储存数据, 或着改用能和原版游戏相容的安全作法

@soarqin
Copy link
Owner

soarqin commented Dec 5, 2022

确实目前字段不足以保存状态,C#的bool字段虽然可以当byte用,但是要patch的地方就太多了,可以考虑DSPModSave。
另外我还少patch了拆除建筑的函数,导致有其他bug,也要一并修正。
另外原本还打算给CompressSave加DSPModSave的支持,后来想想算了,modsv一般都很小。

@soarqin soarqin closed this as completed in 898e817 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants