-
Notifications
You must be signed in to change notification settings - Fork 7
/
gh-test.txt
2138 lines (2138 loc) · 248 KB
/
gh-test.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
sent
"Guess there is a typo here: `translate`."""
"@arturoc: If you multiply-include `gst.h`, wouldn't it be good to add some include guards, so that we don't include it several times, driving up compilation/linking times?"""
"Thank you Vlad. Your contribution to Mangos and TC will be remembered. I admire you so much."""
"@opdenkamp Hi Lars, I'm afraid that you forgot to upload the file to the server. If this is automated and just takes some time, I apologize."""
"Ok, so let's be paranoid."""
"Instead of duplicating warden logic, maybe the test could simply call warden.authenticate!() in MyController's before filter passing the strategy?"""
"Oh sorry! Just need to add a reference to the youtube page in docs/source/userguide/settings/plugins/index.rst. That's this page: http://www.thinkupapp.com/docs/userguide/settings/plugins/ Also the developer guide you wrote isn't linked anywhere in"""
"It is trivial, it can be changed if you consider it appropriate... in fact, I just added this here for consistency I suppose. Cause the easiest way to 'hack' into generating enum values was to use PHPMyAdmin's approach: to use the (already available) """
"yes, :( Last time i specially check mangos.sql Db version at real use with server start. So must be fixed now... and no other simialr problems"""
"one thought i did have would be to use it in config.ru, but then we lose the ability to use AppConfig :("""
"Should cache `jQuery.support.elementTraversing` to a var locally"""
"@trustin it's named """"race_fix"""" .... Thanks :)"""
"Would be to easy ;) and to unobfuscated :D Fabian"""
"This breaks many plugins which use Players as keys in HashMaps and keep them even if the player logs out & back in again. Maybe you should add a way to make a player's entity id persistent as long as the server is running? (I'm opening an issue as well if """
"You can avoid using the HashSet with something like ``` ids.flatMap { // return None if we don't want to include the id // return Some(id) if we do }.toSet ```"""
"DQL injection is possible here. you should not pass the value (which is a user input) using string concatenation. You should use a query parameter here and set the value for the parameter"""
"The docs here describe behaviour that is pretty different from what is implemented in the code. The passed value gets constantized if it does not respond to #delivering_email, which actually is a bit weird."""
"This breaks php-git build :("""
"Use ruby 1.9 hash syntax"""
"I hate you guys. :( I removed all tabs at once and re-done them manually as I copied the code from a version with too many tabs!"""
"given that this could be arbitrary data, do we want to do a hex dump instead? (ChannelBuffers.hexDump(commandName))"""
"https://github.com/EdGruberman/CraftBukkit/commit/9c2f7ab206aa1e580dd8f3cbd34a202c59fbc64a >what's in 'a' name? that which we call a merge... :-)"""
"Since I really don't understand this cryptic lines I just post the error output for you to review: ``` 2>C:\Development\xbmc\xbmc\utils/GlobalsHandling.h(184): warning C4346: 'xbmcutil::GlobalsSingleton<T>::?$Deleter@V?$shared_ptr@$RX@BAAB@@boost@@' : depe"""
"Umm, there's plenty in there that don't :P"""
"tradition with waypoint record ^^"""
"Is this threadsafe?"""
"The bundler fix is great, but `gem install` will still give a confusing prompt about rails overwriting its own stuff :'("""
"you need a blank line after the title so that the next few lines go to `\description{}`; BTW, usually I do not end the title with a period"""
"hmm this is weird, is this the autoformatter?"""
"According to http://tools.ietf.org/html/draft-ietf-httpbis-p5-range-22#section-4.2, Content-Range is undefined on response codes other than 206 and 416. Unless chrome needs the Content-Range header to be present on this 200 response, this set_header call"""
"Heh, yeah :)"""
"Probably costs as much to do: for(i <- v.inbound.averageValue; o <- v.outbound.averageValue) yield ((i,o))"""
"You did, I don't want to live on this planet anymore :("""
"Don't you mean Lives?"""
"Also, sorry for this, I should have revert earlier, I just thought that I will be able to fix it quicker."""
"why not remove autoStart parameter and class property?"""
"There is no way for us to know the root of your Octopress directory, as `lib/` will be distributed as a gem, much like `jekyll`. Do you know of a better way to find this directory? As you can see from the diff, this used to be an absolute directory rel"""
"default should be from the config not in code"""
"Yep... I guess this should be faster Am 07.07.2013 um 10:30 schrieb Trustin Lee <notifications@github.com>: > We can do that, too. We'll have to duplicate and retain it every time. > > On Sun 07 Jul 2013 04:18:22 PM KST, Norman Maurer wrote: > > """
"Ah ... sorry. Okay :/"""
"The sentence is weird. It should probably be rephrased to be clearer."""
"wouldn't inject be more succinct? e.g. <pre><code> filter_chain.inject(Array.new) do |filters, filter_item| filters << filter_item if filter_item.before? filters end </code></pre>"""
"Why does it require a HashSet?"""
"You can configure any provider to be icon provider by setting login_form: ```yaml pam: login_form: false ``` Though, it the wont pass app_id and app_secret as first parameters... Why do those providers require them to be arguments instead of bein"""
"very helpful, thanks! (especially for creature and gameobjects)"""
"Since it's going to be a hack anyway, can the Tempfile compatibility issue be solved like below? def is_a?(klass) Tempfile.ancestors.include?(klass) || super end"""
"All of it. :-) Use two spaces, not four."""
"md5 mismatch Binarycrayon:Library yudi$ brew install pyqt Also installing dependencies: sip ==> Downloading http://www.riverbankcomputing.co.uk/hg/sip/archive/4.12.2.tar.gz File already downloaded and cached to /Users/yudi/Library/Caches/Homebrew E"""
"Ok, as always i wrong read post, anyway not care about any crashes without useful info..."""
"Tbh no idea, i don't have sniffs for these, just based myself off the sql comment blocks :P [EDIT] Sems a bit more logical though."""
"XemsDoom: +1 This commit is terrible mistake, and I'm not going to continue in this %#@& !"""
"The emphasis is on IF. :) Anybody can simply add that spell to eg. SAI. The crash log should come from some kind of fun server. Anyway, feel free to drop out that (maybe hacky?) check, but in that case you should drop out the check in Spell::EffectActi"""
"Since nobody seem to care that we break working addons from Dharma..... Then i think we atleast should make getcwd() fail the same fashion i made chdir() fail. That way we don't get weird subtile errors from addons using getcwd(). Imho they have no busi"""
"~90 LOC just to avoid a goto? I think that speaks for itself :)"""
"Good call, it wasn't encoded before, looking into why..."""
"Hurray!"""
"But lying on the class makes it useless."""
"Of course it did... I assumed everything was in proper order. Thanks for the heads up"""
"Well, in that world `Number.isNaN(obj)` will work correctly too :)"""
"oh.. and I pulled the plug on dwarfforges... http://dev.bukkit.org/server-mods/dwarfforge/"""
"the else if must be in its own line, add a linebreak after the }"""
"move this in SD2/EAI - hack much more, then current commit :) all simple object interaction like this must be realized by spelleffects or procs - see sniffs. PS curious why you started to worry about the quest, which in the current core is still impossib"""
"Can we add a default return? throwing an exception sounds a bit too much for view related code"""
"MAke it so that the dispatcher to be used is specified through the constructor, in that way it'll be easier to configure it later."""
"Apparently missing the `s` interpolator."""
"DoCast(colossus, SPELL_MERGE, true); is too hack :P but that problem is in CheckCast for SPELL_EFFECT_CHARGE (i think is bad pos z)"""
"I agree, I will change it."""
"@ry you should read nodejs-dev from time to time. :) I cherry-picked it from badger/c-ares@bffd67f."""
"the naming of these 2 services is weird. The first one uses the extractors but the second one is not an extractor. It uses loaders"""
"also this issue closes #504 (forgot that sorry!)"""
"Sorry, guys. Yes individually tests pass. I am working on a fix which includes moving this form constructor to beforeFind, to ensure correct ordering. Sometimes tests fail because the find results are incorrectly ordered. I have setup postgres now, so i ca"""
"Maybe this was a bad idea"""
"Then we're on the same page :-) Alright, could you do me the favor of squashing the commits into 1 so it's easy to cherry-pick it into 2.0.4? Great work! √"""
"Creature* c > Creature* creature Heh. D="""
"Yay nice fix."""
"Why is the Sanitize class deprecated? Is there anything else that replaces it?"""
"Actually it *should* still work on pre-3.0 I just have to test it. There is no checks done on what flags you are setting so since the values are `static final int`s they'll be compiled in the code. They'll be ignore as flags on those platforms but you shou"""
"I whisper this one: looks like a huge step to ahbot implementation. Yay ;-)"""
"depends lines go after md5, before patches"""
"Hi, I not find tests, but they start issue https://github.com/FriendsOfSymfony/FOSFacebookBundle/issues/79 but fix not work :) 2012/3/22 Drak < reply@reply.github.com > > > @@ -79,11 +110,35 @@ public function regenerate($destroy = false) > > */ """
"win32: 'sqrt' : ambiguous call to overloaded function while trying to match the argument list '(unsigned int)'"""
"I think it should be either `has been removed` or `was removed`. Also, wdyt about adding the commit examples to the changelog?"""
"I know Twig supports ``none`` as an alias for ``null`` because of its Python inspiration, but does it make sense to keep it in this ExpressionEngine ?"""
"ok, no idea how to format code blocks in github comments :-/"""
"A empty query(using where) should just ignore the condition returning to normal query, intead of a exception or return 0 elements. Do not you think? Post.where({}) is somethink like SELECT * FROM posts (WHERE NO CONDITIONS). If a have a dynamic hash """
"Well, I guess I'll be taking my leave like @V10lator. I need NBT and it's clear after more arguments that it will not be supported, probably along with an AI API and packet API. Edit: @mbax That was the reason why I was planning to include independent """
"This is inconsistent with the other UNIX implementations. The caller is responsible for not passing in NULL."""
"@dmethvin: that sounds fine to me, but in my opinion in that case the name `isEmptyObject` is not adequate (that is why #7413 exists). Perhaps we can use `isObjectEmpty` instead, and deprecating `isEmptyObject`?"""
"I don't like that syntax at all. It's not type safe, and therefore doesn't prevent silly misstakes or help in refactoring """"foo"""" must be('defined) cluster.convergence must be('definod) """
"because hack shit methods must die."""
"Thanks to have already fixed this bug."""
"if (events.ExecuteEvent() == EVENT_DEATH_YELL) """
"Adding the parameter in the middle of the signature is a BC break"""
"typo here"""
"Unstable for Public servers? They are not supported by Trinity xD"""
"Yeah, just add additional commits."""
"this is wrong. you should not talk about the service id but ask a csrf provider. the bridge is usable outside the full stack framework"""
"You are right."""
"@benschwarz as far as I lives in Russia, I have to tend to develop interfaces for at least two languages - Russian and English. I18n is best for it ;)"""
"Component(1) was totally working before =( could you bring it back?"""
"Relevant: http://twitter.com/ajpiano/statuses/148842137751003136"""
"@markstory Why do you trim the dot from the domain? It can cause security issue. The `cakephp.org` cookie domain is accessible only by the `http://cakephp.org`, but the `.cakephp.org` cookie can be accessed by `http://cakephp.org` and `http://bakery.cakep"""
"great:D """
"I request a revert of this commit :("""
"Because that keyword only has use for constructors accepting 1 argument without a default value."""
"Needs to be documented that it's blocking"""
"im just sayin . why you taking time to respond lol . i have no idea how this works , im just here for cookies"""
"This is a BC break as the signature is not the same anymore. You should add another method that enables to switch on/off the HTML extension."""
"And it's an import so I can't make it dynamic... Wow. New plan. Import org.* and import net.* Horrible idea but fixes the issues... Now to just fix the bytecode issues..."""
"The session_id() call is probably a better solution than setting $_COOKIE directly. I'll change that."""
"Yeah, sorry about the username non-sense. I registered as """"rwldrn"""" a long time ago. I also have """"rwaldron"""" but that doesn't have any of my project stuff :\"""
"do you mean 1f96ccdfe24ffedd9eb303f73f5985a3a127e203 by cyberium? saw this while trying to backport schmooz' patch and cyberiums is missing on mangos one :)"""
"Yes, they are still necessary to support HTTP pipelining (server side) and connection pool (`Agent`, client side). `_buffer()` keeps data until a socket is assigned. When a socket is assigned, `_flush()` writes the buffered data to the socket. The follow"""
"I can see a decent reason to use the `DjangoJSONEncoder` as the default as it gives us `Decimal` and `datetime` support for free. These are very common use cases for django sites (especially datetime!)."""
"Ah, true. I forgot about that. Browsers... :("""
"This method is synchronized since javax.security.auth.login.Configuration:getConfiguration() depends on system property """"java.security.auth.login.config"""". We need to make sure that the login configuration object is based on the given storm configuration, """
"the default name should be changed to something more intuitive"""
"Ah... No - the pathInfo contains the stuff between the servlet-mapping and the query-string. From the spec: \[pathInfo\]: a String, decoded by the web container, specifying extra path information that comes after the servlet path but before the query stri"""
"Flame Leviathan is bad example, because it always follows one particular target at time, regardless of threat levels."""
"Welcome back @homakov. FWIW you got your message across. Not sure you could have done it any other way. Take this as a lesson all you devs, take all your bug reports seriously."""
"Could we rename this to `newBoss()` like other factory methods in our public API?"""
"This is most likely a bad default"""
"The rule you guys used in the past with the ie.less was the following: a img { border: 0; }"""
"I'd probably prefer a simple if: val interval = routeeProvider.settings.retryLookupInterval if (interval.isFinite) // Retries enabled retryTask = Some(context.system.scheduler.schedule(interval, interval, self, RetryTick)(context.dispa"""
"scratch that... it's under 70 seconds now. (hyperthreading is weird.)"""
"Thanks @trondn for the fix."""
"yay, doxygen!! \o/ thanks Gotisch :) @vlad: we know, that _YOU_ have the whole mangos code in your head (you can probably even run it in your head without need of any compiler...), but almost all other persons need some kind of documentation... ;) """
"base64.b64encode would be even more efficient, I was simply reporting the bug"""
"@jnicklas, as I wrote my message I wondered how many people from the EU would make comment. What I really wonder is why the authentication library should handle the i18n at all. Surely this could be handled by rails. In my opinion the generated views"""
"No sorry, insider42 based. dont this problem exist in clean core?, maybe Pala and DK spells related Best regards"""
"eclipse formatting due to the `;` break it to two lines, or enclose in `{}`"""
"yep, it's work, but i need to add user and password for proxy connection=( Can u added this feature. May be --proxy=login:pass@server:port"""
"yeah okay my bad... disregard last 24hrs of comments"""
"How would you disable CSRF on a form then ? There are probably better solutions than what I have proposed, you should submit a PR when you have a working one."""
"Aww man, it's a cruel world, eh?"""
"this is wrong IMO as you are loosing part of the data in case of a composite key without saying anything to the user"""
":confused: """
"sorry -- this is my first formula and that was an extra line of copy/paste -- Deleted"""
"I see. In fact, I worried this change. (because break FOSFacebookBundle and ...)"""
"Can we revert it now on master? =)"""
"`$this->kernel->getStartTime()` cannot return null. So you can safe a condition check. Btw unrelated, kernel->getStartTime() returns -INF, which is probably also problematic as INF not always supported and it violates the phpdoc which says, an integer is"""
"off in development mode"""" -1 When I am going through the hell of fixing IE rendering bugs I am working in development mode. I want pages to look exactly the same when in production. I don't want to add a IE hack to find out it creates another bug in pr"""
"sigh...it is not a question of syntax preference. It's an abstraction that adds no value to the underlying scripting language. It's not worth having the argument of whether it's nice or not (which is entirely subjective)...it obscures without adding value """
":) cool, thanks."""
"@vlastv Please read about the form-urlencoded serialization of form data for checkboxes: - when they are checked, they appear in the submitted data, and the value is the one set in the input (which may even be an empty string IIRC) - when they are not ch"""
" Uhm oh yeah. Hmm I would just go with Name (Handle)"""
"nice catch :)"""
"Hmmm, I just downloaded it on my desktop and sha1sum says your checksum. But https://github.com/rapid7/metasploit-framework/wiki/Downloads-by-Version shows the b9d6dbe54b23448da9a939cf3e1f95cb7dc0e363. Though the download link for *that* file is http://"""
"`if event.target.nodeName isnt 'A'`"""
"Not sure if I like this idea. I get how having a variable for this adds some flexibility, on the other hand it isn't likely that you will have one font color throughout the whole site anyways so I'm not sure how useful it is. Using the color set in a pare"""
"I also find setElement a little confusing, perhaps it reveals the inner workings more than necessary but not sure what would be a good name, pointTo?. Also i liked the old syntax you had where you got objects for each element you wanted to modify but p"""
"Can any tell how much is CPU load in % on clean mangos, with ~100 players?"""
"cofirm @digz6666 double loot... """
"This is just amazing. Thanks for adding this code to use in bukkit."""
"I think BytesRef.toString is too verbose since it uses 4 chars per byte ('0xc3' for example). Maybe we could directly call `currentPayloads[j] = Base64.encode(curPaypoad.bytes, curPaypoad.offset, curPaypoad.length)`?"""
"very thx ^^"""
"you mean the problem lies in their implementation using WeakReferences and their associated extra GC cost, right?"""
"I'm afraid it also contains a fair bit of Engrish, both in spelling ('avaible', 'build-in', etc.) and grammar."""
"Formula updated to address this (would be nice if brew audit warned about this...)"""
"Since all of the cases where `format_object_header()` could have returned an error code are now handling by asserts, it should never fail (except by asserting), so I don't both to check the return value for < 0 anymore. Does that seem okay? """
"wrong realization AKA hack. see spells 48586-48589. """
"Thank you so much!"""
"This comment is pretty useless"""
"I wasn't aware that expressing an opinion on committed code based on information from the PHP manual in an open source project was """"spamming"""" everyone. I also wasn't aware that it notified every single collaborator, so cram your elitist attitude and have s"""
"It probably won't make any noticeable difference but a continue would be in place, indeed. I actually thought of it but then forget about it again, so nice catch. :)"""
"There is a problem when running this new FaceMaterial example with WebGLRenderer. I'm already too tired to sort it out now, but the problem is apparently coming from faces which do not get randomly assigned material, which means their material is undef"""
"Sorry, I didn't make it clear that such a test should be performed only for Opera. Other browsers already are burdened in different ways for their own errors. But I get what you're saying... too many issues with too low a success rate to be worth it. I'"""
"Actually, here is [one example](http://travis-ci.org/#!/thoughtbot/paperclip/builds/67058)."""
"Hehe, hadn't quite grokked that, thanks :-)"""
"True! Is not `unescaped`, is `unreplaced` or `escaped`. Then, should I change it?"""
"We may want to use `_isfile`, just for extra sanity?"""
"Hate to add noise, but I would really prefer to have links to the issues as well. """
"Blank lines before and after `depends_on ...`"""
"you could also write ... if (roll < 73) ... to prevent calculating the random number in this line - one might be enough :)"""
"Bad Scott! Bad!"""
"Thanks for your comments and tests! (Aptana is driving me nuts, I'm currently searching for another IDE)"""
"make that N330 pretend it's a single core with no HT and you should see any issues :)"""
"this param don't exists in the method signature"""
"@trustin ups thanks... stupid osx :/"""
"note: this is a hack, if you have a better way then please tell us"""
"Please, use 1.9 hash syntax, thanks :)"""
"but but but ferals are fluffy, not overpowered :'("""
"can you tell me what issue(s) this was causing (like which api you were using)?"""
"Standard way of determinating euclidean distance. If you used it once you will recognize it :) http://en.wikipedia.org/wiki/Euclidean_distance"""
"Glad you fixed it"""
"I guess my comment was vague, I was sleepy. There seemed to be some compile, errors. I'm at work now I'll post them when I get back home."""
"As i know warlock's pets is permanent pets and should follow to owner if owner is mounted (this how it works on blizz servers), so with this if (pet->IsPermanentPetFor((Player*)this)) ((Player*)this)->UnsummonPetTempo"""
"Why did you chose to seed with 0 instead of a counter?"""
"yes it'd be more complicated I think: I really don't know the details so don't trust me but as I understand it if you want to sync audio on video you'll have to feed it with timestamps and set some compensation. The compensation / async is set at swr_init """
"Actually, maybe not. I see that encode actually encodes all the attributes if body is blank. What if I want an empty post?"""
"Sure, though I'm sure we'll only ever have one hehe."""
"pet::Update call Creature::Update and in creature update before chnages exist explcit assign different value to regentTimer In some cases Pet regen timer updates conflict with unexpected Creature updates and timer never set less that normal diff values. """
"Long live the thread-safe code! :)"""
"great - okay, makes sense. thanks for going through these all - yay, less yellow triangles! ;) feel free to merge!"""
"this commit is going to make writing tests so much more difficult :("""
"thank you for improving movement system. now, i can see the face of boss when combat : ) """
"Then how do we get the current planned drops? I need it for my graveyards plugin edit: Nevermind, i'm a blind idiot"""
"Shouldn't this and the following methods be called `openSession`, `closeSession` etc. to be consistent with the naming in the rest of the framework?"""
"Oh, I've misread commit title, my bad :dancers: """
"ups.. missed it. Thanks :)"""
"Nice name, buddy."""
"yea forgot the space after if mate :]"""
"That password isn't actually the password, it's just a random string, so I don't think I'll filter-branch it out. Thanks for your vigilance, though."""
"It's always sad to see a reference like that go, but it was probably a good move."""
"Actually, with the removal of case insensitive comparisons, this is obsolete!"""
"LOGIN_DEL_EXPIRED_IP_BANS double?"""
"This appears to be only used in log output. If so, we should avoid calculating it in normal operation."""
"Why this change? :smile: """
"Instead of sniffing for IE, you can use the IE-specific [`document.documentMode`](http://msdn.microsoft.com/en-us/library/ie/cc196988\(v=vs.85\).aspx) property."""
"I think this was the only comment you skipped =)"""
"Thanks, this issue has caused us serious confusion on numerous occasions. """
"Hack:p"""
"+1 This looks super useful!"""
"ah, sorry"""
"`const` also helps the compiler generate code that makes more efficient use of registers tiny function though, probably doesn't make a difference in this case"""
"That's great! Love to hear that ;)"""
"`brew audit frei0r`, this version tag might not be needed."""
"I think its quite clear when the person has a look at the interface whats what :) Another alternative would be to rename the DecoderInterface into EncoderDecoderInterface to make it even clearer."""
"I hope it is not patronising if I offer this : http://gist.github.com/329172 Thanks : DBJ"""
"weird tabbing and bracketing here"""
"Just use issue tracker."""
"Well, we had problems with rawurlencode, because it encodes '/' and other that cause issues with Apache just returning a 404 or 500 (not sure anymore) without even hitting PHP. There's a ton of different ways to plug PHP in a webserver, and every webserver"""
"For users, it probably don't have to be mentioned (it's a documentation). For developers there are unit tests (+docs) :)"""
"It's more disappointing how long it takes @Subv to add a simple Typeid check :)"""
"@tadd agreed - I wasn't aware of that syntax. I've added your suggestions and pushed. thanks!"""
"You mean semicolons? :P"""
"I like this name change!"""
"Please add parentheses around the `and` block, precedence isn't obvious."""
"Sorry for the bad commit message."""
"Any chance we can get definition duped on the way in? These deletes can cause some bizarre issues at times. See http://github.com/ernie/paperclip/commit/ef2e871ac1015a67e27b7a8a8c0da35842ed97bb for one fix."""
"sorry, totally tried to be @MrZyx, because he said postgres i think... sorry all."""
"Well, I think we should clean the CS. The CssSelector component was originally written with underscores when porting it from Python but the CS have been fixed latter."""
"Yes, much more descriptive. Done!"""
"Does this regular expression work if I have ? within quotes? I also don't know why we are doing the replacement rather than leaving it to the server? This seems pretty dangerous."""
"@Dinnerbone you should rollback this change apparently it crashes clients. I tried it now and it's true... sorry :("""
"You right i not remember about UNIT_FIELD_CRITTER (in fact first time read about), BUT I not """"put hack"""". I update _existed_ field to ObjectGuid. Start use UNIT_FIELD_CRITTER field if it related to minipet can be good step but independent from this or late"""
"weird, when I tried last time, it feared all npcs around me..."""
"That sounds like a record!"""
"They are all just lines. Thus I would make some utility functions that created sets of lines that could be rendered using the standard Line.js class. But I am unsure if you are looking for additional functionality on top of just generation."""
"man, am sorry but who you are to ask developers do anything?"""
"I dunno where can be problem :( I have in fog just cave part, but no the """"souls effect"""" around. I also think Spirits in Frozenmourne are bugged. In 1st Frostmourne had no spawns, in some of attempts attack instantly after teleport and sometime work perfect"""
"Ideally we want all style in the stylesheets"""
"From what I understood, if `tryTupleApply` returns true, then the subsequent logic in `tryNamesDefaults` will choose tuple application and won't go for named or default argument applications. Right?"""
"No need for the extra line."""
"Awesome work everyone, it's beautiful!"""
"Also `man1.install 'gpg-key2ps/gpg-key2ps.1'` IIRC."""
"Yeah that was the question of tge TODO... Do we want this? Sent from my iPhone. Excuse any typos.... Am 03.01.2013 um 16:27 schrieb Trustin Lee <notifications@github.com>: > In transport/src/main/java/io/netty/channel/ChannelHandlerUtil.java: > """
"That's not 'broken', that's ack 2 working as expect. Report it upstream."""
"// somedev1 - 6/7/02 Adding temporary tracking of Login screen // somedev2 - 5/22/07 Temporary my ass jk ^_^ couldn't resist"""
"If there are no references to it, it means that it's been terminated, if it has been terminated then DeathWAtch has been triggered. No need for WeakHashMap"""
"I don’t think you want the `!dragging` here—this behavior should only be controlled by the clamp setting."""
"Crap..."""
"Ouch, that is not a very happy thing for me. I use tons of datasources that do not extend the base class :("""
"trail and error has the downside of making backports for the subprojects real hard. For example its almost impossible to backport lots of stuff from TC because you never know if the backport is wrong or the commit simply was experimental stuff. Trust me, I"""
"@spastorino, please don't forget to push this to exceptron as well!"""
"Watch out, you'll be crossing paths with [MCFTIDE](https://github.com/scala/scala/commit/a205b6b06#L40R128)"""
"Brilliant, I didn't realise that homebrew would generate the checksums automatically. I've amended the file again to include this. Do I need to create a new pull request or should my changes be fine now?"""
"Unfortunately that would still be too much: as symbols mostly come from different SourceFiles grouping is not benefitial."""
"well since it's an undocumented feature, I'd say break it. To do it like Django does ;-)"""
"GOs with gossip without hacks? epic!"""
"`brew audit gcutil` and remove this version tag if it isn't needed."""
"Sniff it! :)"""
"what a shame.... :("""
"Good call. Simplified."""
"WTF ?????"""
"And WOW, how the crap did _that_ happen? Apologies for the double-post. I blame sunspots."""
"@josevalim are you sure that we need this `indifferent_hash.rb` file? :)"""
"Spawned GO still in mangos not have real size... and ofc, geometry also... unknown way calculate it :( """
"Multibyte::Chars is designed to work with UTF-8. Some references: https://github.com/rails/rails/blob/master/activesupport/lib/active_support/multibyte/chars.rb#L7 https://github.com/rails/rails/blob/master/activesupport/lib/active_support/multibyte/char"""
"total 392 8 -rw-r--r-- 1 andriytyurnikov wheel 1734 Oct 11 2011 ACKNOWLEDGEMENTS 8 -rw-r--r-- 1 andriytyurnikov wheel 983 Oct 4 01:29 AGREEMENT 280 -rw-r--r-- 1 andriytyurnikov wheel 140111 Oct 9 01:54 CHANGES 8 -rw-r--r-- 1"""
"I've wanted a method like this for so long! I'm always writing little bits of code to do this. Thanks!"""
"We've never allowed these, sorry."""
"Is there an elegant solution for this problem or we should drop it on the floor like we do now? Poor java guys..."""
"@normanmaurer I think you or trustin may write an post on you website about the release() and retain(); this may be important things to understand in netty4,and you may need to make it clear to the readers. Thanks."""
"IE9x64 on my Windows 7 VM does ~6200 reps/s of `jQuery('<div id=""""foo""""><span>bar</span></div>')` without this change and ~5800 reps/s with ([source](https://gist.github.com/990134)). You'll probably be able to run more accurate performance tests than I hav"""
"he collected data on exceptions"""
"No... you haven't got me correctly. Method is gonna always exist on `Request` object. The problem is that if the argument exists, it returns it. Otherwise, it throws an `InvalidArgumentException`. Look at the implementation of method `Request::getTruste"""
"I'm worried that this change will break existing sites with no way to recover the old behavior if they are relying on it. Thoughts?"""
"Perhaps I'm being pedantic, but I'd prefer the new validation to be added in a separate commit from the reshuffling. Ditto for other new code this commit that I might not have seen."""
"evil fix!"""
"Love what you did there."""
"I think it stands for unsigned long long."""
"pull a _why and make everything as cryptic as possible, that's what good programmers do. job security ftw"""
"Actually, looking more closely, this CSS isn't specific to login/register? or is it? Right now it's everywhere Bootstrap is enabled, but it looks pretty login-specific. What do you think?"""
"Thank you. <3"""" - Alien Blue users This issue caused a massive uproar on /r/alienblue."""
"Ah. Cool deal. Thanks, John!"""
"Nice spotting, sir. Thank you!"""
"@rehv https://github.com/Bukkit/CraftBukkit/commit/8f12382e8efc8c39a919af9180dd884caf3720ff#commitcomment-2274858 >I'm fine with whatever solution that doesn't force devs to recompile every CB version or so Good news, this won't make any dev recompile """
"One assumes you're aware of the following: Set<T> weakSet = Collections.newSetFromMap(new WeakHashMap<T,Boolean>));"""
"That's why this is called a learning project. We are sorry that your servers don't work as immaculate as they should. Things are done with trial and error, and believe it or not this is still volunteer work, so no one should really answer to every cry for """
"Done, tests pass without the whitelist now"""
"coding style: brace on next line"""
"val NATFirewallAddresses = getStringList(""""akka.remote.nat-firewall-addresses"""").asScala.toSet"""
"Oh my... I remember I stopped and looked at the word, it looked weird but kept going... =_="""
"I will. we have support for List<T> and Dictionary<T> coreclr safe deserialization now. Unfortunattly we did not find a way to support HashTable deserialization without making its protected constructor public, which I expect is enough to not want that """
"grats - first stable thing in eden i guess :D *running*"""
"Oh, sorry didn't see that :/"""
"shouldn't this be an Error not a warning?"""
"Comment: Short circuiting is available if: - no full comparison requested, only validation for a certain ordering (ordering ne FullOrder) - state Same has already violated (see states and allowed transitions in my comment below) and the requested orde"""
"This line saved my ass. Thanks! I did a fresh install and after that, the SSH Keys added by the users didn't appear in git's authorized_keys file for some reason. (No errors where shown) With this line it works like a charm :+1: """
"I can't find SAI for www.wowhead.com/?npc=23859... didn't you forget to convert his script?"""
"I'm getting this on linux: ../../../src/game/Object.h:521:7: warning: no newline at end of file"""
"Unfortunately, I found someone using this [in the wild](https://github.com/nbudin/devise_cas_authenticatable/blob/master/lib/devise_cas_authenticatable/routes.rb#L16). I'll file a ticket up stream, but should we make this a warning?"""
"A single-use non implicit Ordering is an unlikely sweet spot. Skip the Ordering and write ``` sortBy (_.name.decoded) ``` instead of sorted treeOrd. """
"Can this use the preprocessing util?"""
"> Weird, this is what I get: > http://twitpic.com/3agtdb/full My bad, I reverted my changes, rebuilt and now I see it (Lucy has strongest effect). Must have been some caching issue. > By the way, I'm a bit confused with the ratio the refraction us"""
"Thanks Mike. You said it better."""
"Did you intend to only whitelist the AbstractDownloadStrategy class? Pondering replacing with ```ruby when Class then @strategy ```"""
"die-hard designers would probably rage over SASS/LESS/Stylus as well, however css does have the fundamental issue of not being dynamic, so I think that is a different argument"""
"Oh, I didn't realize! Should have checked the audit. I've removed the version string."""
"It's ALSO for display. Although I doubt the practical use of your case, especially considering what this fixes (copying from URL encoded VFS's), reverting maybe a little drastic. I think a far better fix is simply adding a check performing an IsInternetStr"""
"hmm ``` for (uint32 resistance = 1; resistance < 10, r>=probabilitySum; ++resistance) probabilitySum += discreteResistProbrability[resistance]; ```"""
"Ofc, but my secretary (monkey) in random typing by keyboard not always type proper texts to commit notes. ^^"""
"looks like this didn't work :("""
"Congrats with your first commit and developer status at mangos! Do we know you from forum? Good Luck and thanks for joining!"""
"It wouldn't be in net.minecraft.server or obfuscated if it were new :) The changed lines are always marked with //craftbukkit."""
"code is better than documentation :-)"""
"even better would be to add a comma at the end."""
"`positionPercentHack(elem, name, value)` => `positionPercentHack( elem, name, value )`"""
"@jeresig - Right I get that *(and auto converting rgb would be fine)*. I just don't dig swallowing all potential errors :/"""
"MD5 issues here too :("""
"I don't think this is correct. @arrbee?"""
"Oh, sorry guys. Got distracted by other things. I'll split my submodule branch and push up some options today."""
"So move the yelling to a central place? Great idea."""
"I think that translator is missing one fallback search level. In my opinion there are 3 levels of fallback I've set in config.yml the default translator fallback to en I've done some translations in English (en) and Italian (it). mybundle.it.yml mybundl"""
"That's a good thought. Hm."""
"Looks great! love `OF_TTF_MONO`, etc"""
"So how will the writeHead merge handle multiple headers? If it's an array then append, otherwise overwrite? There's some nuance here maybe. res.setHeader('set-cookie', 'single-value'); res.writeHead(200, { 'set-cookie': ['more', 'cookies']}); I"""
"Heya u sayed Fix multiple permissions and remove multiple config option… but where is the config option for RBAC ?"""
"i know malsup's Taconite plugin replaces jQuery.httpData. maybe that's why it stopped working when i tested 1.4.3pre a few months ago :\"""
"http://2.bp.blogspot.com/-Boq9ZwPglK0/TlQUl5VZ7tI/AAAAAAAABqw/AaicADRN2hA/s1600/404_Not_Found_nginx.jpg i want speaking about that :D pony are everywhere"""
" i don't get it, why do you override DateTime#to_time? DateTime.now => #<DateTime: 2012-01-25T11:33:21+01:00 ((2455952j,38001s,996469000n),+3600s,2299161j)> DateTime.now.to_time => 2012-01-25 11:33:25 +0100 looks like offsets are allrig"""
"finally :)"""
"i'm realy confused with github... i can't edit my edited file"""
"Yes I was reusing Rack initializer but that way I'm passing NullSessionHash creators the responsibility to define a null store which should be in NullSessionHash. So agree. Fixed https://github.com/rails/rails/commit/e3b9b25aa3cbe6344425a346e6e73073ca6"""
"re: """"Use Props.empty instead guys."""" Genious. And obviously it's in the docs... I just read it... :)"""
"In RFC 2109 an explicitly set domain must always start with a `.` (section 4.2.2). Only if the domain is omitted will the leading `.` be missing (section 4.3.1). Based on the domain matching examples, the rules seem like a cookie's inclusion in a request"""
"This looks intresting, now.. hmm, to get up with some nice scripting idea using this :D"""
"Thanks for fixing it, you saved my OCD :P"""
"My bad example is at fault for that one, sorry @antonio!"""
"The issue is that a lot of the people starting these debates are too strongly opinionated when they really don't have a say. """
"unsigned int"""" in order to get rid of the sign-compare warnings in line 240 and 242."""
"Gratz Zergtmn! Very good job!"""
"may offer this: https://github.com/rsa/mangos/commit/fdf656d23a114f5dd3fd17ec77b7ae766bade4a2 not need with current mangos code, but required for thread-safe. tested, worked fine."""
"`decodePdu` should be lazy wrt. decoding the actual payload, since we might throw it away in untrustedMode (it might be a mem bomb …)"""
"*sigh*. I'll fix. :'("""
"What about local XSS attacks? With unescaped output, something akin to the MySpace worm is enabled by this change. Granted, Rails coders *always* remember to escape output! :) But was the intent to remove a layer of defensive programming?"""
"Epic fail... let's build enterprise so?"""
"Thanks Ben!"""
"Yeah, what the crap is going on with that last line! Let me fix that right now."""
"`Oldie` insures no past or future browsers that have broken parsers could ever possible apply the IE hacks, but I like `lte-ie8` better. I would advise just using php(that's my preference) to convert between the classes and hacks on the fly. Just right """
"oh, I missed the comment bits, my bad."""
"\ No newline at end of file"""""""
"This breaks gossip options :("""
"Hey! This problem prevents all European folks from usage of paperclip... I am sad about it :-("""
"Nice catch. Leftover from the evolved development :)"""
"I think the reason why we don't have ::Parse() URLDecode is that it could cause problems when manipulating the CURL filename member and then re-using the CURL object. It would be better then to put this in URIUtils::GetFileName(), I guess. Since I didn'"""
" if (Initialized() && !Finalized()) full spline is sent"""
"session.reset() is invalid in this scope. Lets remove it and then work on a different approach. In my ExampleServlet I had to use `this.request.getSession(false).invalidate()` to get it to reset the JSESSIONID. Simply using `session.invalidate()` was no"""
"Ok thanks very much for your explanations. And thanks LordJZ too :)"""
"You have a point there, it would be good to get rid of this. However, the opposing constraint is that when there is no custom Hashing object, some objects produce poor hashcodes for typical object ranges - for example (n: Int).hashCode == n. The problem """
"Hope you didn't hate me too much for not having commented there in the first place :/"""
"My bad. Suggestion was only pseudo code. It doesn't handle 'folder creation failed' and returning: true or false. I meant something like: https://github.com/itofzo/Sick-Beard/commit/247339e45aef0a915b0208c27de8c8621bdc57e0 """
"Hi Gina, `oauth_access_token-client_id=12345-client_secret=dummy_secret-redirect_uri=http%3A%2F%2Fmytestserver%2Fmythinkup%2Faccount%2F%3Fp%3Dfacebook-state=testiferricous-csrf-token-code=thisisatestfauxcode` The length of this file name is **testife"""
"I also tried it, and hardly less than you:) so far obtained. though of course very easy to write ..."""
"I'm updating to Rails 2.2 and I got a lot of deprecation messages like: DEPRECATION WARNING: @change will no longer be implicitly assigned to change. This deprecation check seems to be a little overzealous. If I set an ivar @change in the action and"""
"Thank you, guy-who-probably-lives-in-the-Balkan."""
">I'm pointing out the fact that Gee, you make it so tempting to feed. Guess I'm going to have to resist though :("""
"One more point for you on the unlimited """"why we love you""""-scale. Have a nice day."""
"I'm curious about the performance implications of adding another call to the stack. """
"Good idea ;)"""
"@Machiavelli - I WILL NOT SIR! Are you trying to get my hands burned even more!! You crazy man you!"""
"You don't really needed to fix these problems because jzlib was on the exclusion list but on Windows it didn't work because of different file separators. It's good to clean things anyway. :-)"""
"i hope the next change will be fixing a bug that aura 269 affects resilience =)"""
"I think that it may be better to handle the """"Trick"""" (roll_chance_i(50) returns false) through spell 24714 which requires script effect. Your """"Trick"""" code looks like it would work perfectly there though :)"""
"I don't understand the thinking your response. I helped you avoid a bug. How does that make me """"upset""""?"""
"At least, Visual Studio compiler remove any ASSERT in release mode, so the function is never called. I Had a hard time with that :("""
"Progress progress!"""
"Yes, this is best: ```javascript exports.PORT = +process.env.NODE_COMMON_PORT || 12346; ``` Hooray! A bikeshed! Let's ALL paint it!"""
"LNK2019: unresolved external symbol """"protected: virtual void __thiscall ByteBufferException::PrintError(void)const """" (?PrintError@ByteBufferException@@MBEXXZ) referenced in function """"public: __thiscall ByteBufferException::ByteBufferException(unsigned int"
"Why should we then even trigger the SEND_HEADERS event? We can also register a listener on MVCs EVENT_FINISH and forget about SEND_HEADERS event. You can also remove there unneeded/ unwished headers."""
"holy damn >_>!"""
"This seems to have awaken Issue #1789 again, why do you changed scroll to offset ?"""
" s""""cpuCombined must be between [0.0 - 1.0], was [$x]"""""""
"I think there's a mistake in this method, `columns_hash` is not correctly being used, as @tenderlove has fixed in d29235d2a4df94b6db7d3e45ab15a6799363384e for branch 3-2-stable. I'm going to forwardport his commit to master, @yahonda can you check it agai"""
"Unfortunately, the contents of the checkout lines in the reflog are not guaranteed to be a branch name. In my reflog for libgit2, I found: `<sha>^0`, `<sha>`, `<sha prefix>`, `FETCH_HEAD`, and `<branch>` """
"/* just ignore this shit. TODO write more code */"""
"Cannon spells bugged..."""
"kandera, congratulate to join team!!!!"""
"Thanks"""
"MaNGOS have nowadays gold era :)"""
"Hooray!! Thanks everyone. :)"""
"Yeah I think we should make the interface return `Future[Unit]` :\ I'll file a ticket"""
"Okay. A comment would be nice, otherwise LGTM."""
"Recompiled version works fine, sorry."""
"Hey what happened to the EncryptedCookieStore?"""
"closes #10517"""
"This line is so confusing. :cry:"""
"good catch, thanks!"""
"Remove these comments"""
"This change breaks routing that worked with subdomains in the past (2.0.4) as it redirects a failed login request to /users/sign_in as opposed to /[subdomain]/users/sign_in. Can this change be removed for the 2.1.0 release? It's the only breaking chang"""
"`/** */` to make a documentation comment."""
"the test or in the implementation(ActiveModel::Serialization#serializable_hash)? If we do it in test, we are not actually checking any order. this test will always be passing because of `sort` call. """
"lol, nice commit message dave"""
"Well, we didn't have a migration in a while but it is in the usual update workflow. Rails will also print a pretty clear error message in case you miss it. So I don't think that's necessary :)"""
"That's not right, `X509_STORE_add_cert()` takes ownership of the certificate."""
"Give one of them a different name. (What that name should be, I don't know.) Also, the first new gunzip method should probably also be gunzipStream for consistency (and with the same signature collision problem)."""
"Fixed the syntax for checking the presence of email and password with mongoig"""
"There goes my weekend. I beg, BEG, you to revert this."""
"Agreed `DjangoJSONEncoder` would be better default encoder class."""
"line endings: http://help.github.com/line-endings/"""
"if i have my server set to hardcore people will be banned on death ??"""
"BURN HIM!!!"""
"That's right. Forget me, I'm silly when I wake up."""
"yeah, you're right, sorry, didn't noticed that there is only one amp symbol."""
"broke jasmine:ci :("""
"Fun trick: you can use `Object` instead of `function(d) { return d; }`. But the identity function is probably more readable. :)"""
"I'm at Railsberry conference now. If someone can provide a clean fix - it will be great :smile: """
"Should the signature be (d, i)?"""
"It might be best to do a source compatibility hack here instead of copying the constant. In Analyzer.scala, there is a class Compat. Maybe add: ```scala val DummyValue = 0 def hasMacro(s: Symbol): Boolean = { val MACRO = Flags.MACRO // will be DummyVa"""
"crazy, I remember writing this code awhile back... I put it up on the mailing list but never got around to writing a test for it... """
"You're welcome. I was just about to remove this completely as I found that in fact it was already fixed. :) Cool you chose it instead!"""
"Don't use `Zend\Json\Decoder`. Use `Zend\Json\Json::decode()` instead, as it uses `json_decode()` by default. `Decoder` should only be used in rare occasions, typically when the JSON is known to be in an encoding other than UTF-8, or where you know JS lam"""
"we should remove authorize() and just have login() with an optional set of permissions. in most cases apps will want to tos the user and request permissions in one shot."""
"Shauren did forget something ... *screenshot* :p"""
"Gridmonster fools us all !"""
"haha, no. I don't trust a global search and replace on something like this. Now to do our plain Makefiles that are not autogenerated."""
"Another bug introduced by alias abuse. Tests for this file fail."""
"@coelho Great point :+1: """
"I miss C++ :("""
"Sorry, I thought my comments were sufficient: ``` If the code includes a valid, prologue position strict mode pragma, execute code by injecting a script tag into the document. ... Do the injection. Otherwise, avoid the DOM node creation, insert"""
"yes i noticed that after i send this pr -.-"""
"don’t use `Any` in Java-facing signatures, Paul warned that there is pain lurking on that path"""
"Hi, thanks for the fix. but what about the MultiSelect?! it's just working with single select :8ball: """
"good, this one makes simplier doing backup"""
"The methods `get()`, `set()`, `has()`, `all()`, `clear()`, `remove()`, `replace()`, `isEmpty()` and `keys()` [are missing](http://symfony.com/doc/current/contributing/code/conventions.html)."""
"I can start on that right now and make that the next push. I realized that I was trying to do it all at once and I need to break it up. Something that should have taken me a day ended up taking a month :( This is the order of how I was thinking of doing"""
"Thanks for the link. Will fix all related issues."""
"How do I go about benchmarking the strict build to see what the impact actually is? It feel wrong to me to take decisions without metrics. Never used our benchmarking suite so I'll need some help here."""
"+1 :D (i never used that)"""
"Whoops, amazing that this lasted a year in the repo :( I fixed things up in [27ab9093b5be7ca16192982d4f6640130d963421]"""
"the problem is: this is an overwrite of a reversion-admin function and i wouldn't like to change the signature of the function"""
"yup I considered writing my own, but the benefit isn't very obvious :-)"""
"What an entertaining read. Nice!"""
"Happy to see you going by hand, but the Ragel parser had the advantage of the graphical Dot state machine output. Are you maintaing a similar FSM for this version, and if so, would you please copy the .Dot file into the repository? Thanks! """
"i dont get it what is this for ?? sorry for my noobish question"""
"Sorry, maybe this was the formatter that I used too (as the indentation), was not my intention to make this... I'll rollback... Thanks"""
"@jeresig: committed and made pull request (http://github.com/rkatic/jquery/commit/452c292daa8de2d45cf283bd51cc98d90e04327f)."""
"@leprechaun This should be: ``` BotoConfigLocations.append(os.path.join(os.getcwd(), """".boto"""")) ``` This avoids an invalid path on Windows. Also spaces after or before parenthesis aren't preferred according to PEP8 which I believe @garnaat is trying to"""
"I donno. I would start by seeing if this is still an issue. It seems odd to check for only the primary window *(as if only the primary window object would bug out, and not say an iframe window object)*. I don't see any other place in the `add` method that """
"FYI - this breaks rspec-rails' monkey patch of AC::TC, so rspec-rails-2.0.0.beta.8 does not support rails from this commit forward. I just addressed this in rspec-rails, and will try to get an rspec-rails beta 9 out soon. http://github.com/rspec/rspec-rai"""
"we try to remember, but when we push broken code we need to fix it as soon as possible (we don't have a versioning scheme) and in that stressed moment forget about ci. also, it's difficult to explain ci to open source commiters, and when a commmit needs"""
"Why do you do this either way, ```options['login_form']``` is ```true``` or ```false```? Shouldn't this depend on ```icon```, instead? Something like: ```ruby if icon Gitlab.config.omniauth.form_providers << provider end ```"""
"I've absolutely not read all of the comments but I just have to add that we should have done this commit WAY earlier. The whole point of Bukkit is to *NOT* provide you access to the Minecraft internals directly. This changes makes it so that you *HAVE* """
"Really appreciated this!"""
"i only fixed an obviously broken script, not debated its blizzlikeness"""
"I still don't understand what this stuff has to do with WebKit. Anyway, would be cool to actually find the root cause: the change I made here was just in the way I set the HTML for the frame. I can only assume that the frame requires a """"physical"""" fil"""
"Yes, they certainly should!"""
"@Ne0nx3r0 https://github.com/Bukkit/CraftBukkit/commit/8f12382e8efc8c39a919af9180dd884caf3720ff#commitcomment-2305605 >@mcfacilitator When we're given permission to discuss this on bukkit.org I'm sure most people would be glad to do so. It would be nice t"""
"Isn't this weird?"""
"Because, a fully functional retail like AH with simulated seller to represent a working economy would make TC even more blizzlike :)"""
"improvements*"""
"yes, sorry the ifdef is incorrect, it's fixed now"""
"Oops, my bad sorry. I was using 2.4.0 rc1 ... this is correct for 2.4.1 (which is now the default installed by pip)."""
"haha, you have made enough good commits already so no sweat ;)"""
"We don't do interim builds, but I'm preparing for the next NuGet release which will also be the starting point for the v3/v4 split. WebHostUrl can be explicitly set to point to a preferred external url, which if it is it will use that instead. """
"In order to get the most out of it the decoder can decode frames in advance (the thread does not block in flipPage). This way the one or other decoding cycle can even last longer than refreshRate without the need of dropping a frame. vdpau decodes, the"""
"Yes, please."""
"@ADmad Very true! testing with ```array_key_exists()``` now. @markstory @ravage84 It does, but I targeted master because I considered a bug: . throwing undefined index when a key is not in the ```viewVars``` array . returning a JSON encoded array whe"""
"Bad :|"""
"Yes, as I was `git add`ing it, I thought to myself """"maybe you should rethink this."""" I'll fix it. :smile:"""
"Getting weird errors in WebKit with this error. Will be investigating further tomorrow morning."""
"That's weird. It works for me locally: ``` mbp:activerecord godfrey [3-2-stable_restore_frozen_state_on_rollback] $ rvm 1.9.3 mbp:activerecord godfrey [3-2-stable_restore_frozen_state_on_rollback] $ ARCONN=postgresql ruby -Itest test/cases/transactions_te"""
"This causes a style guide violation and makes it harder to move towards `onevar`"""
"@riking very nice."""
"nwsw is correct, there is an abstraction layer, and you simply need to use BaseFacebook and provide the three hooks to set/get/clear session data. Using $_SESSION makes it work out of the box, without having to store the access_token in the cookie."""
"I had it implemented that way originally. The `rijndael` function uses substrings so I decided to make this the same. Being more strict is an option though."""
"ok now again :D where can i get new map,vmaps extractor for windows ? compiled ones plz.. dont say me to compile etc.. i have reasons."""
"@Runemoro Clients crashing because of a packet change is the BEST CASE scenario. It could have spaghetified the world. It could have deleted the whole server folder. The trouble with using the obfuscated NMS code is that you can't control what your methods"""
"Hm, where are coderay options used in kramdown? http://kramdown.rubyforge.org/options.html"""
"Players are opening the chest with spell 61437, might be possible to force that to be casted by the player on gameobject use. And tbh, I rather see sniffed positions then """"working"""""""
"You're right, sorry. I should have redirected stderr to avoid the spam. I was checking in this case because new Macs apparently don't have an unset path - rather, they have `/Developer`, which is invalid but not unset."""
"hooooooray :)"""
"On Thu, 10 Jan 2013 11:03:10 -0800, rsa wrote: > @billy1arm [1] , If you have not realized, this """"developer"""" > completely > (by some last commits) destroyed the possibility of further work on > the code - that you yourself have yet to learn. As for workin"""
"Why is the `-d dist` needed? I thought dist is the default?"""
"I am geeking out over the bug and the fix. srsly awesome."""
"Yep, will add in a separate commit. Thanks for reviewing the code, it is really appreciated :)"""
"I think this entire special-case block and corresponding expense of `.index` can be eliminated if the `jQuery( this ).remove()` on [L296](https://github.com/PaulBRamos/jquery/blob/6fb68d22f4b136f0b467cf060ea3286f8cc6fcce/src/manipulation.js#L296) moves af"""
"The current and advance callbacks share the same type signature so the empty iterator just reuses the same function for both, hence it doesn't follow the naming conventions that the `ITERATOR_SET_CB` macro requires. I could probably rename `empty_iterator"""
"@Seldaek: Using such a path pattern, the `?` gets encoded anyway. So it wouldn't generate a query string."""
"@whitethunder, I told them, but they don't trust me. Seriously, project is an excellent name. More, I'm looking forward for a method like """"user"""" or """"company"""". Also a great idea would be methods """"topic"""", """"post"""" and """"comment"""". =)"""
"indeed. we could either make the tests use the new methods instead (has to be done some day anyway) or simply switch to static calls. But working with E_STRICT is kind of impossible at the moment anyway with the current 2.0 head. too much stuff not yet"""
"No, it wasn't; nice catch. Fixed."""
"Yup, knew I'd forget something..."""
"Isn't it weird that it works with java.lang.Integer but not RichInt?"""
"Ruby should really optimise these kind of things automatically :cry:"""
"why allocate a new String instance? def apply(name: String): Node = hash(name) def fromHash(hash: String): Node = hash"""
"Why not a simple check for `null`? As the provider is injected in the constructor the object will be type hinted? Is this to guard against people doing crazy things while extending the class?"""
"Hmm, sorry for forgetting credits - lost them while rebasing :( First and biggest credit goes to virusav, as he wrote an original patch. Also credits goes to NeatElves and Infernos for problems research Also to crackm for inspiration and tests!"""
"woot - really awesome to see you in here !"""
"can you use Ruby 1.9 hash syntax?"""
"fixed"""
"Forget a """"}"""" I doubt it because the log gives me problems on several lines. I'll see to resolve this and I'll let you know. ;) All went well for the other files it's strange anyway =)"""
"Although I love warpten, I am sorry if I go to fast. code=trinity"""
"Style: we use license boilerplate like this: ```c++ // Copyright Joyent, Inc. and other Node contributors. // // Permission is hereby granted, free of charge, to any person obtaining a // copy of this software and associated documentation files (th"""
"sorry, it's fixed now"""
"`if($connection && $connection->getFieldValue() == 'close') `"""
"Could you elaborate why this is needed? That is, why is a static constructor needed. No idea why so I am curious :)"""
"At this stage I'm not sure the rails core wants or cares about this fix. :( cc @fxn @steveklabnik """
"oh nice find, that's been bugging the crap out of me"""
"He-he http://filebeam.com/ab2603ca3af8b3130bbcac8da807677c.jpg I wrote: """"Sorry, wrong patch) Please delete this issue """" )))))))))))))"""
"Thanks a lot ^^"""
"@tarcieri I don't appeal to the authority. We are talking about formal languages. In Ruby 0 is true. That is a fact. Given that fact, the one that has to justify that it is a bad idea that 0 is true is you. And you need to argue with language designers."""
"> that's really old and annoying bug. It's not bug until it not propertly reported but just user _personal_ problem. Must be fixed in [11255]"""
"WTF???? OMG ((("""
"What's up with the really amazing commits lately? Thank you!"""
The issue is only with passwords that got the high bit set on some chars for some specific combination of chars (not even valid utf8 chars). I think many could live with that minor risk. I myself would want to use this code also on pre 5.3.7 platforms
"There are always odd things like `--single-branch` that come up and you should be able to implement without hacking the library. A client might want to copy default config over or do other weird stuff. `git_clone` is great, being able to do it yourself if"""
"Yes, it is! And I want to remove one from `node_crypto.cc`, but @isaacs disallow it."""
"This is just another of the things I noticed and fixed while this pull request was waiting. I don't believe I can create multiple pull requests with the different bits so it got included here. The reason for this change is that the cookie_expiration_pe"""
"Will this also do scheduling? If it could monitor loads then prioritise queues based on that would be pretty awesome."""
"What does """"the names are encoded"""" mean to you?"""
"This is not very readable plus has unnecessary merge with empty array. Better to replace with this: ```php if ($merge) { $this->_inputDefaults = array_merge($this->_inputDefaults, $defaults); } else { $this->_inputDefaults = $defaults; } ```"""
"yes... i'm sorry... but this bullshit.. any stable commit for 1 month) I should be happy? ofcourse - i have be terrible of your emotions... i want stable working of my server and nothing more.. How can break an off repo? I can not express it in words...."""
"My CI server agrees :) -- Kenneth Reitz On Friday, April 13, 2012 at 4:39 AM, Bradford Toney wrote: > Python 3.x doesn't support .encode('hex') > > --- > Reply to this email directly or view it on GitHub: > https://github.com/kennethreitz/requests/"""
"i will do a new PR to fix this. sorry!"""
"ok, sorry for my reaction, fixed in recent commit"""
"That is how it was working before, I tried using model() but got several errors. I'm merging this as it is passing the tests, but I'm open to suggestions for improving it"""
"I spent almost an hour thinking about this code snippet. I wrote some comments, then I erased them 3 times. Seems to be ok. Since we now have the verification cache, and that cache proves to be fast, maybe the safest thing would be not to do anything in """
"Good to see that we use DBC's in more cases :)"""
"ah okay - didn't realize that the MAC_OS_X_VERSION_10_7 isn't define on 10.7 running 10.6 SDK. nevermind then - what you propose is fine!"""
"There may be too many APIs related to path handling. Sorry! I just extracted this one since it was such a common pattern in the code."""
"makes me more sad to see people complaining that we fix our own mistakes..."""
"@stloyd wow, I was not aware of this method! I update the PR now, thanks."""
"Confirned by testing in game. Thank you :) I look currently how this can be used in code..."""
"It should only search for 'core/Loader.php' as the Loader class can be extended."""
"It helps debugging, and no security is violated as there is none :)"""
"Lol."""
"when tests running with Netbeans (all tests in folder) - this is problem because in Mvc/Controller/TestAsset/ exist the ZendTest\Mvc\Controller\TestAsset\Request class. """
"Knock yourself out :-) Even something that's replaced later that does the job would be better than nothing :)"""
"seems you even didn't tested this change. This bug already fixed by this commit (see DB part)"""
"i like InnoDB more :D"""
"This documentation disappeared in the process :-("""
"thanks! I've learned something today. :) ``` ruby case record_or_options when Hash options = record_or_options options.assert_valid_keys(:etag, :last_modified, :public) else record = record_or_options options = { :etag => record, :last_modified ="""
"Agreed with Vincent-Michael, at the moment many of those scripts were written people did not know how the spell system should work, as an example you can take script for righteous defense, which is an extreme violation of spell system rules."""
"why not ``lang_template['hide_untranslated'] = getattr(settings, 'CMS_HIDE_UNTRANSLATED', False)``"""
"To avoid `isInstanceOf` on every `computeHash`, I could replace the `hashingobj` with a custom internal `Hashing` which does the mangling if it's a class returned by `Hashing.default`, yes."""
"ScriptName removal won't be needed? -> http://pastebin.com/zF5xks2v (Still got to find out how to put proper comments in here) Ha, this should be it<pre> -- Inquisitor Hallard scriptname removement UPDATE `creature_template` SET `ScriptName`='' WHERE `entr"""
"That describes what options get generated for the homebrew formula itself. We want to add the guard to the line because if the user doesn't request lua, we don't want vim to pick it up on accident (which it might do if it is already installed and we se"""
"Sort this constants with the old first"""
"Not really related to this particular commit, but why do you use DIRECTORY_SEPARATOR (even in it's shorter DS form)? It seems unnecessary, as using / will work on all OS, Windows included. I think your code would look better, and be easier to read, if you """
"Indeed, that's why I asked you :)"""
"Oh right, I didnt see it, ty =)"""
"I considered it, but currently s3 only offers one encryption option so a bool was enough to get it done. However I can see them adding other options in the future in which case passing a symbol that indicates type could make sense. Lately I've been tryi"""
"Neat. I wouldn't pass up the opportunity to use a crazy trick! :)"""
"Thanks bro, missed it! :smile: """
"rsa, i glad to heard that you can configure your own compiler and, stop talking about multithreading, clean mangos sources has no MTMaps, """
"thank you very much :)"""
"I didn't know about libev. I'll check it out! Thanks."""
"@isaacs ```js function Deflate(opts) { if (!(this instanceof Deflate)) return new Deflate(opt); Zlib.call(this, opts, binding.Deflate); } ``` it should be `new Deflate(opts)` (The commit is to big to add proper line comments ;o)"""
"sorry i just got this wrong... this iteration is just for applied areaauras... but this must be related to some aurahandling changes afterall"""
"Edit - just checked with my python script, I got 1350 records for ytdb 619 :) http://paste2.org/p/1981677"""
"WHEN REPORTING ERRORS, INCLUDE THE GOD DAMNED ERRORMESSAGE/COMPILERERRORS!"""
"This is included in the next line automatically."""
"Indeed it should :)"""
"`g.src=('https:'==location.protocol?'//ssl':'//www')+'.google-analytics.com/ga.js';`"""
"alil late a dollar short, nay .... the moments passed... :D nice language btw... i got over it... so np <3 ;)"""
"If this is only used in one place for one usage I'd rather just use ConcurrentHashMap and make sure that whatever gets put into it only has identity equality defined"""
"I guess we should move it back. This is pretty weird tho"""
"I've just updated this feature."""
"I agree with @grumpydev here. There should be no ctor just for testing purposes. If it's difficult / cumbersome to create a fake certificate then maybe we should provide some test helper for that instead. If the Ctor was already there then it must've been"""
"if we have GRANT USAGE ON * . * TO 'mangos'@'localhost' IDENTIFIED BY 'mangos' ... So use login """"mangos"""" more correct than root. No lol."""
"I'm sure you didn't mean to do this :)"""
"Method of """"trial and error"""" - the most efficient in the case of the development of open source. Welcome to the real world :)"""
"Removing `Apply` subclasses will break implicit highlighting in the IDE, in the worst case forcing us to fork the IDE for 2.9 and 2.10. The change in itself is fine, but let's not slip this in one day before a milestone goes out."""
"Don't put this on the prototype. People will get clever with it."""
"I agree this is a big ugly hack that will break more than it will fix. The original script should be kept for other systems. If necessary you can use uname to discover distro/version and switch proper logic using that. (but I guess there are better solu"""
"Oh, no, see what you mean now. Fixed."""
"yaaay :)"""
"Damn sorry for messing/merging in your area theuni ..."""
"@syamn don't worry, plugin authors can easily update their plugins, just like when a new minecraft version comes out :)"""
":cat: :cat: :cat:"""
"Thanks a lot seph for fixing this :)"""
"@mbax, @EvilSeph, here's a simple solution that does the work: First implement a version checking mechanism is CB that looks for """"target-versions"""" in plugin.yml. (If current craftbukkit version is not in the list, then not load plugin and print """"XXX pl"""
"nice Unit::GetUnit is so ugly!"""
"Oh, I just noticed that. Good point, sad times :("""
"Good call, removed!"""
"Obfuscated code :)"""
"Graz! ;)"""
"Thank you, boyz :) Next target - prepared statements :)"""
"No need to repeat the name of the documented element. A factory to create MessageQueues for an optionally provided ActorContext"""
"Is this code path ever followed? I mean, will an unsigned integer ever be larger than (unsigned) -1? """
"they are right, i have sniff checked"""
"@Shauren 0bb86a3e97cf720512ae00c9bee209a30c5fb928 This patch still needs some further fix."""
"Is something like this: https://sourceforge.net/apps/trac/xbmc4xbox/changeset/30905/trunk acceptable?"""
"Oh noes, code style. :( I'll be super careful about that in the future. Too many projects here."""
"That was the easiest way to recognize a h5bp project :)"""
"Thanks for your amazing work, Malcrom ^_^"""
"Test case needed: ```scala // BEFORE scala> val x = """""""" x: String = """""""" scala> ((x: x.type) match { case a => a }) : x.type <console>:9: error: type mismatch; found : a.type (with underlying type String) required: x.type ((x: x"""
"@Razer6 you are right. I did not noticed #4594 :("""
"@elupus should we set the same strategy for HasAudio? Currently audio visualization pops up for a short while when starting a video. I think this is the reason for that."""
"Yes, it would be really cool if you could update the wiki. But don't forget to say it will only work from version 1.4.0 forward!"""
"ok, thx for taking the time to answer ;) great work!"""
"Oh for Ruby 1.9 hashes! :crying_cat_face: """
"Fair enough. I'll redo the entire thing, it was a bit hefty in the end :)"""
"@V10lator ``` try http://pastebin.com/FcNGtFDV ``` @mbax will be happy then ;)"""
"Sorry, that was lazy... :/"""
"Maybe Jlogger? cheers On May 14, 2013 7:30 PM, """"Parker Moore"""" <notifications@github.com> wrote: > As the commit message says, it was a hack to get around pygments.rb's use > of the Ruby stdlib Logger. I guess I should rename this class, but I > co"""
"I thought you meant 3-bytes, sorry."""
"Yes please do, would appreciate it =)"""
"Commit [11000], jeez! :) ...I joined when mangos rev was only [1527] and now it is 11k - nice progress, I'd say :)"""
":+1: @holman. but who knows how many apps have this issue and don't even realize it. :("""
"that wouldn't work, cause it would return a symbol hash key, which is not a json primitive"""
"This means we are modifying the original options, no?"""
"Great! Thank you again!"""
"i cant translate french :["""
"Assuming you don't depend on deserialization and/or base64 decoding for verifying integrity (see my other comment below), then maybe you could defer deserialization until after you have verified expiry. You don't need the deserialized object to verify in"""
"Also why enable this one by default and not the other ones? It's pretty annoying having to enable them in every new project."""
"@Wolvereness Oh sorry i meant CB 1.1-R8 haha... Anyways, i wasn't talking about bukkit versions, i was talking about official minecraft releases. Also! Now i seem to be getting a lot of crazy people complaining about my projects not working on the lat"""
":x: This not follows your own method signature. Expected string passed Exception instance"""
"This line break our apps :( The only solution I know is change the session key to make their cookies expired. """
"Why?"""
"I agree - lets fix it up there as well...."""
"The documentation wasn't updated. So encode has to_xml's documentation. Also, why is the API changing in a point release (2.1.1)? Shouldn't this have waited until 2.2, and a deprecation warning added in 2.1.1? """
"fyi I don't think this has worked since this change, no flash messages :("""
"@grum >The other solution is to apply random obfuscation to any CraftBukkit build on everything except the main methods and the Bukkit API. > >Maybe we should just do that. ...Wow, are you serious? Im speechless.. as @rehv said, that makes me scared"""
"@davidben and @anthonyryan1 I landed this since there was a good patch (even saved 1 byte gzipped) and I'm glad it solves the problem. To ensure we don't regress on this we'll need a unit test; contributions welcome. I've opened [ticket 12040](http://www.h"""
"Do you really expect the client to disconnect (and the player to be unloaded) between lines 33 and 43, or between 43 and 50? If yes, then there's now an exploit to avoid damage by disconnecting between 44 and 50..."""
"Because the old text """"src/qt/res/src/*.svg"""" had covered the newly generated src/qt/res/src/bitcoin.svg i had to """"rewrite it arithmetically"""". :) I think it's okay like this."""
"seriously, stop discussing your bugs on completely unrelated commits"""
"Wow... Mangos rullz :) It's a great day for our community."""
"onlinetime is spammed anytime worldsession opcodes are handled... its not like it is supposed to work i intend"""
"Don't like it, either. Ok, we'd better stay with deserializing parameters before passing to the `Invoker` - it's much cleaner. But I'd get rid of static extension methods in favor of something like. `IParameterResolver` interface + implementation, that'd """
"`_protect_identifiers()` is supposed to be a protected method, but currently it's public because all the drivers use it for DB forge. There's a `protect_identifiers()` method (no underscore) that I believe exist solely for this purpose - can we use that i"""
"@CelticMinstrel Agreed, not impossible, but nearly impossible. :)"""
"I'm disappointed by this commit, unless it fixes a bug. Does it fix a bug? I also wanted to get rid of the code duplication, but @rwldrn had asked me to wait till grunt was integrated before making further changes to the test suite. My plan was to have php"""
"yes that could be hard :)"""
"`GitHubAccountAuthenticator` sounds reasonable."""
"I'd like to add you to my professional network on LinkedIn. - Sam Sam Rose Student Ambassador at University of Glamorgan Chester, United Kingdom Confirm that you know Sam Rose: https://www.linkedin.com/e/-15j9z5-gs0w7njf-1k/isd/4048244323/Yqb0l5AJ/?hs=f"""
"If the method signature is the same as the parent there's no need to redefine it. I'm not sure why you're even trying to do so. :-)"""
"`depends_on` should come after the checksum and a blank line, i.e. ```rb homepage ... url ... md5 ... depends_on ... depends_on ... ```"""
"ThrowTypeError"""
"This should probably be moved to the `debug.xml` file as the `ErrorHander` is only registered when debug mode is on. We don't want this listener to run in the production env."""
"Nothing there is related to this commit. I would guess you do not know what are you importing, mixing old character and world updates together."""
"Looks like automatic conversion to me (also the original script author is an idiot)"""
"crash ! :("""
"Well done, thanks for not being stingy on the mc-dev update :)"""
"Nice solution. Definitely should start using this method."""
"lololol good catch"""
"@akaariai small comment typo."""
"I think this is checking false to avoid keys with `nil` value to be a failure"""
"Different styles used in the file. I selected this one, as `@see` is not related to the function signature. Where can I read guidelines for docblocks? Especially regarding aligning different parts of docblock."""
"nice to hear this, good job !"""
"Ahhh yes. Brain fail, sorry!"""
"All I gotta say's we got passionate people here and I look forward to all your commits and releases... I guess this one wont go away without a """" You $%#^ Semicolon Nazi* """" and thus voila! * http://en.wikipedia.org/wiki/Godwin%27s_law )"""
"cool"""
"If you want you can, if not I can go through and fix the old code. There isn't a phpcs test for this which is why it is inconsistent."""
"It basically tells the server to convert all int's into strings. This is necessary because we use 64bit ints on the facebook side, but many PHP installations are still 32bit -- and fail terribly when trying to json_decode 64bit ints. By requesting strings """
"Why this change? I have a big aversion against """"new"""""""
"Why is this being removed? It's only a """"duplicate"""" to improve performance."""
"Botched the commit message on this. This just fixes browser support information."""
"Yea, all this is extremely weird."""
"i don't know ruby, what does this syntax error mean ? Library/Formula/chkrootkit.rb:32: syntax error, unexpected $end, expecting kEND """
"case m_targets.m_targetMask & TARGET_FLAG_SOURCE_LOCATION lost in this implement :("""
"Makes sense, I haven't tested getters/setters yet"""
"I think a type alias that is used only once `MultiHashMap` is probably not that helpful. I'd just inline it so there's one less thing to lookup when one is reading the code. I think the same goes for the `Responses` alias. In particular I prefer to rea"""
":metal: Love getting rid of the duplication"""
"@davidwindell I forgot that this was on develop. :)"""
"You didn't :) i was giving an explanation why it does not have comment and some code is commented out :)"""
"... but when `statisfied?` is called, the build environment is not yet set up, so it is not satisfied :-("""
"In principle LGTM but a regression test would be good, I'm not able to trigger a memory leak with getPeerCertificate()."""
"Ooh, a reason to bring mmap and map2 together in mmap2!"""
"No moar YouTube and vimeo? No moar hearts? :("""" +1"""
"@wsoltys Sorry bother you but i still get no git version http://paste.ubuntu.com/782072/ also got some annoying virus warning. see xbmc forum"""
"I see two issues here: 1) It's easy to overflow length on platforms where size_t is 32 bits. Not directly exploitable but something to keep in mind. 2) length is unsigned here but the length argument to SetIndexedPropertiesToExternalArrayData() is a s"""
"hmm, how can we make a route in that file public if the standard security setting sets everything in it as non-public?"""
"Can you make this red?"""
"I can't put this together right now, but would greatly appreciate someone else doing so."""
"cheating, stupid GM's... additional checks - not bad."""
"I don't think it should be a notice. The fallback from fr_FR to fr is totally normal for instance, and this would be spamming your logs."""
"Ops, that seems to have [failed the build](https://travis-ci.org/rails/rails/builds/6066789) =("""
"If the git:// protocol fails for some reason, try again using http:// This will make the fall back discoverable for people who are not aware that they have a firewall blocking git"""
"That last sentence also reads a bit odd."""
"Why are we renaming these functions? If we stick the original func name, we will have less code to worry about. No?"""
"I was thinking last night we should maybe build some of this into appconfig, so we could just say AppConfig.service.twitter? or something like that. I have made many typos with these damn hashes.. :P #justathought"""
"Because the build system changed to require them since the last release (over a year ago) and while we could include them as general dependencies, they aren't needed for the release version. When FontForge is next released, they will be needed as general """
"@Schmoozerd thx for a fast, good review and your help in develop"""
"Also, I'm not sure how I feel about this being within the ServiceBusMessageBus class, feels more like a ServiceBusConnection function. However it is this way in other scaleout providers :("""
"no equals and hashCode for this one? why not case class?"""
"I think this is not necesary because buff is given by the mount. Also if you remove this line the """"fly hack"""" motion without mount is fixed. """
"I wonder if it wouldn't it be better to implement this in `Geometry` instead. Then, at the end of the `JSONLoader` call `geometry.applyMatrix( new THREE.Matrix4.makeScale( scale, scale, scale ) )`."""
"@CorrieKay I'm aware, I'm just really entertained by the screaming contest above. :D"""
"I like this mutable keyword. Only the cache is updated for better performance next time round, so perfect use case I think. I'm happy to do this, but how does it sit with OF convention? Does it work on all OF compilers? Also, the bHasChanged flag will be """
"Style."""
"ALTER TABLE `character_queststatus_seasonal` ENGINE=MYISAM; in world misc ?"""
"abused as poor man’s option"""
"rbac_group_roles"""
"<button onclick=""""alert('speaking of security....')"""">hhahaha WHOOPS"""
"This line might be going a little too far. It obfuscates whats going on by putting a really really big ternary in the way. Can you roll it back or try to make it a little more readable?"""
"when I write this I was wondering using the set or add.thanks ,the set is more good."""
"nah it's a none-node related C project, thanks I'll check it out!"""
"I renamed the methods to `addViolationAtPath` and `addViolationAtRelativePath` in the latest commit."""
"Yeah, I think so"""
"yeah. I also liked the way it was. I think that the default 404 is going to cause the most confusion, It makes me think """"I dont want to return a 404!"""", and I'd probably delete it. Saying that, a magical """"super"""" is probably equally as brittle. A"""
"looks like soon we will have a fully unstable core :))"""
"Ah, good. Okay, leave it as is."""
"lol. nice to meet you. Didn't actually expect you to reply. It's nothing really, just your events (specifically BlockPlace) is such a godawful event. :( I was just venting a bit."""
"yes :) Edit: Well - most spells should actually work correct with dbc-values. the rest could be considered exceptions or custom."""
"This is ugly..."""
"Congratulations, Lightguard! A new dev in the house! /cheers"""
"rsa i not meaning as fix your horiable hack written wihout attempt understand real problem. My patch in gist fix _real_ porblem with wrong """"future"""" msecs time in object last update field. But not resolve all porblems. You pointed """"fix"""" just """"recorrupt"""" b"""
"Dude, ytdb sucks."""
"@Garrett: Perhaps you missed my thanks in the commit message? Definitely appreciate the input. @jdalton: When you get the volume of questions, support requests, possible bug reports, and other miscellany that I do related to jQuery it significantly help"""
"Thanks a ton for taking this on, @domenic. I just signed the CLA. I think I've forgotten most things about the V8 API since I wrote Contextify a couple of years ago, but I'll check over the code and help any way I can. I've accepted various pull reques"""
"Oh God. I'm having trouble with PRs on GitHub. Awkward. I'll better make another one using a fresh copy of Symfony."""
"Changed it."""
"This is a bit hackyish :)"""
"I'm very sorry, it's my mistake. I removed this line, could you please review this again?"""
"Dennis, you rock. Seriously."""
"When using the `useUploadName` option, should we be doing any sanitizing of the $_FILES['name'] value which will be used as the target filename? The `basename()` should help, and I hesitate to change the filename too much if the user is expecting all """
"I wish PHPStorm had context specific docblock template... :("""
"I'm really worried about SEO and color : transparent; maybe i shouln't ?"""
"Cool ^^"""
"Yup, agreed, and indeed I was mislead by the other issue (which was the UrlMatcher not decoding). I tested and it seems to work all good now, with full encoding. I just decode the / back and turn %20 into + because it looks better and seems to work just fi"""
"Is camera example supposed to be working? It's very confusing now ;/"""
"Let's go with `ensure_reset_password_token!` here too. You can also change the line 47 of this file to call this new method. :)"""
"mysql is weird, this shouldnt work as it does WHERE (npcflag & 0x10000000) != 0 is way more readable (obvious)"""
"That Commented out code should be removed, if not used :)."""
"@coelho Because Bukkit is an open, friendly community that encourages discussion and feedback."""
"why run `data_size = str->Utf8Length()`, just to check for ascii and run it again?"""
"They require it. toIndexedSeq doesn't because IndexedSeq is covariant."""
"d'oh! that's one down. don't forget about """"mail"""" => """"male"""""""
"why is a hack for me work excellent , is like other script (sindragosa), and don't need more complications An answer all spells which are in dbc(like are defined) have theyer attributes and should be using for script of the boss/npc?"""
"evil is such a judgmental word. :("""
"again, another style violation for no gain."""
"This was pulled from the old makefiles and gitian descriptors. It's required for deterministic builds."""
"Thanks for being so responsive to the suggestions!"""
"off course, sorry bother you, i return to 7906 so i cant provide data :("""
"Good work qaston"""
"is `/` allowed character in generated cookie? Then it should be enclosed in quotes, otherwise config will barf."""
"I think that would be great! shall we call the color uniform color_uniform ? Shall i send a PR? - I'd also add a fix for a typo in matrixStack.getModelViewPorjectionMatrix() if that's ok =)"""
"This whole commit looks totally wrong."""
"Had it that way first, but decided it belonged in the same test block. Next time we won't. Good to know. Thanks!"""
"`prefix` is the formula's own prefix, and libiconv and gettext aren't linked into `HOMEBREW_PREFIX`, either. It would need to be `#{Formula.factory('libiconv').prefix}`, etc, since libiconv and gettext are keg-only brews."""
"... and the solution: gem install rake-gemcutter Sorry! :$"""
"So this was the missing path. Nice work!"""
"This can be done as a subformula instead, so that it will be protected by a checksum. See e.g. the `git` formula for how this is done."""
"I see you worked on strings, but you could cut down on the number of required strings if you made them """"Godmode: %s"""" and 2 strings """"Enabled"""" and """"Disabled"""""""
"I agree about that in that case. But i'm talking about the patch in general. There are several places where you replace a disabled state with a timed out state."""
"Objects have their SHA-1 sum which determines their filename, though you could argue that a collision is not something that we handle."""
"There turns out to be one more issue here -- this deleted line defined $owner, which is used below. So seems that it needs to remain. It's used by Session::completeLogin($owner) @AaronKalair , @ginatrapani"""
"Changed it to just be `length > 1`. Not really useful to anticipate weird stuff here."""
"we are talking about a config/ directory under a bundle. How many config files do you here? One for the routing? One for your services? One for the doctrine metadata (and perhaps of few more if you use one file per entity)? That's not a lot of them."""
"Maybe It was already solved: 687e68d88f5e1a7bb6a2d876fbbc5b8c4571d853 #9803"""
"Glad to see this land!"""
"Style: Long line. Wrap at 80 characters max. I believe I pointed that out last night too. :-/"""
"`!=`"""
"Eclipse claims that this type violates the """"Unique Particle Attribution"""" principle for XML schemas. http://en.wikipedia.org/wiki/Unique_Particle_Attribution Can we reformulate this type to avoid this?"""
"http://www.trinitycore.org/t/trinitycore/ticket/307"""
"It was fine before this commit, this commit broken :("""
"This is bad for cherry picking too much happening in one commit. Can this not be don in 4 maybe even 8 separate commits? I lost the plot when the cache changes started =("""
"Because a hidden input field is still affected by positioning rules, like another element would appear with `visibility: hidden;` being set."""
"darn, no I only noticed: 4a136cc is the SHA of the commit we had trouble with last time - this shouldn't be in the repo anymore... maybe one of those machines you used still had the polluted repo on it?"""
"May I ask why you decided to split the regex?"""
"You could also use something like: ```ruby column_names_with_alias.each_with_object({}) do |(cn, an), hash| hash[cn]= row[an] end ``` which is more idiomatic but avoids the array allocations."""
"Finally :)"""
"Breaks lot's of tests. <pre> 1) Error: test_highlight_should_sanitize_input(TextHelperTest): NameError: undefined local variable or method `allowed_attributes' for #<HTML::WhiteListSanitizer:0x1010af260> /Users/arun/checkouts/rails/actionpack"""
"Well this is bad, every update I'm going to have to wait about 3 months for all the plugins i use on a daily bases to update.. I really hope this gets reverted :/"""
"Ah I forgot about that and didn't test properly, sorry. The buildout directory is now included in the install whitelist. I've squashed the commits."""
"Hmmm, it looks nicer like this but now it's very slow on my notebook :(. Curiously now it's OpenGL that is worse than ANGLE. Multimaterials are costly and lines are costly too. I used flat shading instead exactly for this reason."""
"Well, damn ... Quote from the `str_replace()` manual: >If search and replace are arrays, then str_replace() takes a value from each array and uses them to search and replace on subject. If replace has fewer values than search, then an empty string is used"""
"Okay. That should save some time, and it doesn't break the existing tests, so I guess it's okay. I wasn't sure how hard to make diff try on this, so I just turned everything on. :smile: """
"no clue ... i refactored the packaging script at one point to match up with ios and atv2 - i guess since then you lost it ;)"""
"ah, now I get you; hmm, too many Runnables nested here"""
"The FormRegistry being new in 2.1, it seems weird to have a deprecated method in it"""
"Thanks for the commit finally :D I would rather see the account and char ban commands actually work before the vehicles patch :P"""
"It is needed for LATM AAC. It can be removed once we update ffmpeg, but I'm waiting for some Windows developer to test it. (https://github.com/xbmc/xbmc/pull/18)"""
"@chopmo Argh! You're right. It seems I didn't imagine that case. Let me take a look..."""
"yes, but unsafe and useless rename now, batter let been as-is. We can't rename internal sql update guards anyway..."""
"That struct looks pretty good. For the basic version (i.e. `git_clone`) all you should need to provide is how to tell you about progress and what branch to checkout. I think we might want to add a flag saying whether we want to ignore SSL errors."""
"See, exactly the way you respond to my post shows me what an ignorant you are. Thanks for writing a comment though."""
"Typo."""
"There are tickets actually. They are all related to Firefox not executing the string passed to globalEval synchronously when using script tag injection and non-async scripts are being loaded (jdalton confirmed to me this was fixed in firefox a few months a"""
"The first thing is if you URLDecode you need only URLDecode the filename, not the entire thing, right? After all, the rest of the path comes from a filesystem that is NOT to be URLDecode'd. The second is whether it should be done at all. As elupus point"""
"revert this commit fix ^ http://gist.github.com/619376 crash. very strange."""
"interesting fix... ;) """
"@BangL Check out my message about 3 hours ago in this comment section. :)"""
"@vicb: I somehow fail to come up with an elegant solution regarding explode etc. - any suggestions?"""
"So we can't put file larger than 4GiB in index? Sad."""
"I understand that these functions are designed to mimic String equivalents, but I think that Array#from should either return [] or raise an exception if it is invoked with an index that is out of bounds. """"pete"""".from(4) # => """""""" """"pete"""".from(5) # => """""""" %"""
"Bound functions are particularly horrific in V8 for some reason. http://jsperf.com/argument-slicing/2"""
"@TnTBass I don't disagree with a detection mechanism, no. I disagree with the use of dynamic package paths that cause errors at a random time, not fitting it's purpose. Add a plugin.yml setting, it is all that is needed to do what you want plugins to do."""
"Wow! Before: real 8m54.220s user 7m18.483s sys 0m50.399s After: real 7m46.224s user 6m13.979s sys 0m44.507s"""
"for the cookie on websites, we use """"fbs_{app_id}"""", the idea being that only instances bound to the same app id should share data"""
"If i disable cases 0, 1 and 5 crash move to case 8!! http://pastebin.com/NMhSRN5D How i can set GCC to UTF8 encode?"""
"Using event delegation, the dom can be interacted with before onload fires."""" Can you explain this briefly? Thanks!"""
"@mislav Andrew and Tobie have done plenty of code consistency commits. Consistency is a good thing."""
"hehe. I was waiting for the loolz. Thanks :-)"""
"hmm ok or is it from the GM status? though .gm off and .gm visible on """
"RSA want to say, that if fixed one thing, it would be nice fixing it by more wide way for future development, something like this =) http://paste2.org/p/833860 """
"Congratz and thanks for everything!"""
"AGPL == epic fail. Don’t count on getting all that many contributors."""
"This permits SQL injection. User data should never be interpolated into the keys of a find condition."""
"+++++++++++++++++++++++++++++1. Awesome commit."""
"Another interesting update to this method in the same threat http://forum.openframeworks.cc/index.php/topic,6092.15.html"""
"yes, that contains strictly more information. I'd like to use FiniteDuration more in method signatures which expect finite durations …"""
"I have a problem in AbstractToken.php Notice: serialize() [function.serialize]: """"id"""" returned as member variable from __sleep() but does not exist in PATH/vendor/symfony/src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php on line """
"AUTHORS is alphabetized by last name"""
"Aw man, you can't grow trees instantly anymore :("""
"It should be quite easy to implement something more sophisticated using ``preg_split``."""
"Yes you right"""
"Oh sorry ..."""
"So we could leave it as `.php`."""
"what will workerID do? worker.uniqueID looks weird"""
"more SmartAI power ^_^ thanks for this"""
"Wow! Thanks. Maybe the patch and has no relation to the infinite spawn chests, but he solved it perfectly."""
"Yay! :yellow_heart: """
"Where is .destroy() defined? I'm confused..."""
"Oh, sorry - disregard, please."""
"This list is useful to me. I always forget what are the supported methods and I always look this guide."""
"I have taken the bold step of enshrining this advice. https://github.com/scala/scala/wiki/Coding-Style"""
"The idea with a factor of something else is that there is less knobs to learn how to turn. But I'm fine with either. """
"testing"""
"Nice commit! This will help me for encounters event :)"""
"I think the output parameter really needs to be a `git_config_backend_iter **` not just a pointer, so that a new value can be allocated. Also, I suspect some backends may want to support the """"match"""" behavior natively instead of relying on the wrapper t"""
"I agree, QAston, he really does a good job, I was not forgetting that. But maybe the word """"gratefull"""" was a bad choice for expressing myself :p"""
"he means more working quests, hackfixed ofc"""
"Whoops! Looks like something I added as a temporary hack during debugging, and then accidentially left in place. This explains why I had two places stripping quotation marks: this one and my own line 452. I guess I'd better remove lines 442 through 444. M"""
"Try fix Gargoyle, and Ill take a screen :D"""
"Hmm ... but on the second though, I think I'll make the `copy.avatar` to have a `@file` assigned to it first, and assert that `copy.avatar.file?` Then, I'd assign original.avatar to it, and `assert !copy.avatar.file?`"""
"Does not compile on FreeBSD 7.2 :( http://gist.github.com/648972"""
"sniffed ofc"""
"ok, makes sense. i only use the name in the line below, to replace in the driver name pattern, i don't need the actual manager service name. regarding the problem of default might not be named """"default"""", i would inject two parameters then? the paramete"""
"great idea this. could be used to script arenas/bgs/opvp/wg instead of hacking up the core"""
"Next time, don't in this PR, leave trailing commas in array elements"""
"Shouldn't it take which claim to authorize?"""
"Sorry.. this Bug that i mean, caused by commit https://github.com/TrinityCore/TrinityCore/commit/f3ec76faeb63009ddff357a93b61220fc6039f47"""
"Actually I don't think anyone would write `.where(""""something like 'some value%'"""")`. It is more likely to be something like `.where(""""something like ?"""", params[:name])` to protect against SQL injection. For this particular case I see how """".like"""" would be use"""
"Double sad face :<<"""
"Cool, I'm looking at this now"""
" @burnham There is not a single creature that have deathstate set :) There was one before this commit (34297), but i could not find that creature in any sniff (a full sniff of kologarn encounter), so he was removed in 2011_06_27_06_world_creature.sql."""
"Wrong fork. :-)"""
"this should check if the cookie is already set, if so, don't set it as otherwise it will bust upstream caches..."""
"Oops sorry holic, added an extra l by mistake >_<"""
"ok, bcs I have old core and some issues after fixing are not closed :) anyway thanks"""
"If you are signed in and you are redirected to new_session_path, it will redirect you to after_sign_in_path_for automatically. :) So it does an extra hop but for the user it works the same."""
"Have you tried pulling in the same version of finagle that we use for the rest of the project? Too different?"""
"urllib3 does the right thing with threads so it shouldn't break, more connections will be spawned and pooled correctly from what I've seen in the code."""
"haa here it is, i get it now, would never had find this //helpers part def alone honestly . ok thanks to both of you guys and ofc no hard feelings NoFantasy :)"""
"This loop will continue until it reaches the target or hits a cycle, so it won't fail on precision. However, we might run into problems from something like `font-size: 100em` or `opacity: 100`. And even if we don't, I suspect (without evidence) that it's """
"@bergerkiller No!!!! :("""
"@just3ws in your situation, and any other situation with heterogeneous environments, I would recommend adding the bin directory to your `.gitignore`. @dhh's position above is that such environments are in conflict with Rails conventions, so the `.gitign"""
"Also, assigning vars inside a transformation?"""
"This line is missing in the latest version, causing `uploaded_file` always nil. Is this intended?"""
"Why not a use a hash in the test?"""
"Redundant. `@Before` already tells enough information."""
"Nullcheck 'e' here. Yeah I know it's a rare case but it prevents huge bugs in the future. Also, can we change 'e' to 'event'? Obfuscated code and all :)"""
"I know that style guide is not ready yet, but we used to discuss that variables should be named in lowerCamel case. Variable Gender makes me feel uncomfortable."""
"Nice, less typing is always welcome :-)"""
"Shit that was my fault sorry @EvilSeph"""
"so why the reload?"""
"crash log ends with """"ACCESS VIOLATION"""", nothing is there... i just catched that """"VisitNearbyCellsOf """" in console output"""
"Cool. I'm out of town until Tuesday, but I support both this change (with comment about i <= 1) and re-deprecating isResolved/isRejected. :)"""
"All my players can use all gm commands :( I've just run the sql updates :("""
"Should proberly be next instead of end."""
"Please indicate if there is a failing test case, or if the problem is related to an overlapping commit. I can re-factor the exception use in authenticate_or_request_with_http_digest easily enough. All other exceptions are used to provide useful failure """
"lol"""
"There is some code duplication here. I would have written : return $this->has($name) ? $this->attributes[$name] : $default;"""
"BAD. ASS."""
"On Wed, Dec 21, 2011 at 5:24 PM, viktorklang < reply@reply.github.com > wrote: > > > > // FIXME: Dispatchers registered here are are not removed, see ticket > #1494 > > - private val dispatchers = new ConcurrentHashMap[String, > MessageDispatcher] > """
"And no even if the encoder produce nothing there is overhead as we need to store it on every encode as we not know if the next call will maybe not produce something"""
"Sorry, I'm an idiot and can't copy/paste correctly."""
"all auction code expected executed in main world thread only, not in map threads. So remark about not safe just lol."""
"It passes. But instead, I included a test that is divorved from the standard library (ie, it doesn't depend on the signature of `Option#getOrElse`). It was more convenient to test for an error due to failure to eliminate a tail call than to check for s"""
"yes, swimming case missing, but in pet code possible :("""
"whoa. great job!"""
"cool ! now in a """"official"""" mangos. thanks to Lynx3d for a long time vmap developing in fork! """
"If we're only storing the first 32 characters of a 64-character hash, isn't it possible to have two hashes that are not unique? Why not add a unique index to the activation_token field and catch a PDOException on insert that indicates a unique key prob"""
"why ? i used this rev, and i get this error on this rev, my commit is ok for this rev or ? i dont know with rev makes this compile error"""
"Awesome. A migration guide already. :wink: """
"Can this be handled in the actual database adapters? I.e. by putting PG specific code in the PG adapter. Maybe by adding e.g. a `:fixed_string` entry to the `native_database_types` hash, and using `""""fixed_#{type}"""".to_sym` if fixed is true."""
"Or maybe this one is vehicle seat? Just got the struct from client"""
"That's a great idea. Would be a way to also solve Diego's issues with context switching."""
"Everyone hates this commit. What possible reason could you have for not removing it if everyone hates it? There is no good reason..."""
"Formatting of this documentation page is broken from """"## Not run"""" on"""
"Wow.. Thank you for putting this together. I have been pulling my hair out for a bout a day or so now. My application was failing to properly clear logged out users...etc. I am going to download this and check it out to see if it solves the problem I """
"this needs a comment in `ActorCell.newUid` so that nobody gets crazy optimization ideas which then break hashing"""
"@lanthaler @schmittjoh you're absolutely right. I'll propose a PR soon with this only feature (the accept-* headers parsing) and I'll use `preg_split` which is awesome."""
"@kandera: I know that 3rd party scripts are not official supported - That should be only a information for user that has ChaosUA script in use :-) -> I like this script and it's IMHO great and stable. """
"i dont know :[. i only tested it for a few things."""
"piece of art :smile: """
"oh I finally see the problem. Well thats not how its supposed to work for sure :). We should be able to solve this better though by redesigning the tracker a tiny bit. Essentially we want to ask the tracker if we need to render + flip or if we can stay on """
"@cptspiff: Yeah this would be the best future solution although this can't be easily/quickly be implemented. @elupus: Do you mean we should move the URLDecode() call + URL check to URIUtils::GetFileName() instead to make it more generic?"""
"![bike shed](http://farm5.static.flickr.com/4154/5206490512_73bc75b5f2.jpg)"""
"Merging commits from 1.3 has this problem that we loose the visibility keyword for functions :("""
"As a fair warning, we **won't** be accepting pull requests that converts from 1.8 to 1.9 syntax (like the hash or proc syntax). It will just mess Git history and add a bunch of noise when we must focus on 3.2 regressions."""
"So much changes per commit is bad..Hidden issues can be..."""
"Odd, it might be the test being wrong... I remember spending some time fixing the multi insert in sqlite so I was quite surprised it did not work."""
"Was that it? THE THING THAT CAUSED SO MUCH HORROR. D:<"""
"Leave this in the `git_clone` signature. Feels very unnatural here. It's an output parameter."""
"Fixed in #1695. The fix seems to have been so obvious, we did it the same way. ;) I also added comments to make this special case more obvious. :)"""
"Is this thread-safe?"""
"So write a tiny bit of code to rename the nms/obc references to their versioned counterparts and unleash it on your 'trusted' plugins. Feel free to make a public tool out of it as well and perhaps keep a 'you can hackily update the plugin using this tool'-"""
"Cool, it's great to see this headed toward Promises/A! I think it's gonna become the norm for multiple promise implementations to be in play in any reasonably interesting app. I found a situation where I believe it still isn't fully compliant, so I creat"""
"Feels good man."""
"Sleeping is a weird variable name what about receivingMessages or ignoringMessages"""
"yes :-( I know, just saying that while it is broken, there should be other way to fix it (although I don't know how)"""
"poor guy"""
"And in all fairness, I'd also leave `origin_remote` and `local_path` in the function signature. They are not optional, and they are not going to change. So why not leave them there?"""
"@jonleighton you're right! Sorry about that. :( Looks like this code is new in 3.1. Are you comfortable with this going out for rc6?"""
"this should not use concatenation but query parameters (you can have SQL injection through the username currently). Btw, doctrine DBAL supports binding an array as parameter (which is not the case of PDO itself) so it is easy: ``WHERE s.identifier IN(:ids"""
"@opdenkamp: can we make CEC also less spammy ? On the PI it logs a lot."""
"Use 1.9 ruby hash syntax please"""
"Because the hostname will often be used to set a port or connect to a socket it could make sence to parse the hostname about port and socket, too"""
"Ach. Lying comments. Will fix shortly."""
"here we have an utf-8 string assign to a CStdStringW, are you sure it is assigned with the correct utf-8 conversion?"""
@adamv I notice you cleaned this up -- I had actually copied the string interpolated version from existing Formula... If this is the preferred way would this be worth adding to brew audit ( I want to poke around in there for separate reasons anyway...)
"Nice work. :) However shouldn't we have a fail check if the MMaps are enabled but the folder isn't found? Similar to the Vmaps check."""
"Lol, yeah. Damn headers. Would be very nice if someone took a look at the code though. Not sure it was the best implementation."""
"We need only one copy of it - it perfectly fits to be static. Other solutions looks like a workaround/hacks: make variable non-static and create static instance of class to have only one unique non-static member variable. We don't need constructors, d"""
"Renamed, though ... both look weird to me."""
"Nice! That actually makes it much more readable, thanks!"""
"shouldn't 'Doctrine\\Common\\DataFixture' be declared before 'Doctrine\\Common' ? (like 'Doctrine\\DBAL\\Migrations' is declared before 'Doctrine\\DBAL' )"""
"https://github.com/TrinityCore/TrinityCore/blob/master/src/server/shared/Logging/LogWorker.cpp Check LogWorker::svc() it's deleted there. """
"Yeah, it's pretty nice.. it'll be nicer once it's an actual gem (pretty big git dependency, my Heroku slug size is up to 97mb) but I'm not complaining :grin: While I haven't tested this, I have a feeling anyone using TheRubyRacer instead of Node.js as t"""
"Yeah, add another file that's blocking parallel download. No, really. Don't do it. The proposed solution isn't solving the problem, since """"people like me"""" wouldn't remove the file. We also need colors. We would just change them, or not. Please use sane def"""
"Six? WTF man? No oriental sites. And oh yes, point to your own milk-toast, blog-only and fuckall-else sites. Nice work. Seriously. At least point to the list in the wiki. """
"Noooooo! I actually prefer the old style hash syntax because the new one doesn't support objects as keys. :-( ``` { author: person, person: [posts] } ``` won't work for example. ``` { author: person, person => [posts] } ``` is a horrible mi"""
"ROFL, hard, but need =)"""
"I had no good reason for removing this comment - it must have been my mistake :)"""
"Usually we set event identifiers in `setEventManager()`, which ensures that they happen on injection. That also simplifies the `getEventManager()` implementation, as it only needs to call `setEventManager(new EventManager())`. On Wed, May 8, 2013 """
"Yes, it's the node hash."""
"You'd need to escape every regexp special characters (think . for instance) in s.data so that you don't have false negative. Talk about a """"simple"""" hack gone wrong in the convoluted department (not to mention performance and memory issues in older browsers"""
"sure, I am fine to change it to whitelist mode UNLESS it is development or test"""
"You need to put this to require as well because its required for the tokengenerator. Without it the csrf component is not really useful. Also you probably do not need ~2.4. I guess something like ~2.2 is enough (needs examination). Furthermore, its miss"""
"This would have been perfect as a plugin, considering the potential performance issues. I will no think twice before using .data()"""
"`node.createDocumentFragment && node` could easily be misinterpreted as a code bug (it took me several minutes to figure out that its intent is to ensure `node` is assigned and not simply that operands got inadvertently swapped); I’m strongly inclined to """
"<offtopic> sorry for this post here :( In forum you have very nice post about Mangos in production servers make by Kero, is possible to move it to the mangos' wiki? </offtopic>"""
"Didn't really need to do anything special as anyways rendering was already done per material-specific parts, remember geometry groups? Maybe we can just forget about this for now, anyways before it wasn't possible to have object with different face orient"""
"Seems like it should be set as an error that the controller can, optionally, check. EDIT: validator -> controller"""
"I'd fix it myself, but I'm on my way out the door."""
"Maybe explain that pixel arrays are like unsigned byte arrays but with values that are clamped rather than wrap around."""
"argh. sorry for the double post, timed out on the first."""
"Yes, I removed it as I was thinking the signature root.add(d, i) might be confusing. I think it’s fine though, so I’ll add it back everywhere. :)"""
"I know the patch is only about the model... but my eyes hurt and I run screaming after seeing so many explicit hashes like { """"value"""" => """"1"""" } in the method calls. """
"![](http://images1.memegenerator.net/ImageMacro/7266902/EVERYONE-STFU-GET-BUSY-WORKING-OR-GTFO.jpg?imageSize=Medium&generatorName=Scumbag-Steve) You don't HAVE to use coffeescript. I see a bigger waste of time bitching about it. I also see people bitch"""
"I trust you"""
"on the contrary, that was a great suggestion, I just simplified the code because of that"""
"This is Rating (unk1)"""
"You are right. Not sure why I added it there. Thanks for fixing."""
"There is a backdoor in this commit, i'll give a cookie to the one who finds it first:P"""
"Please revert this merge. The assets helper, which requires an HTTP request, is now directly injected whereas before it was lazily loaded. This is causing all sorts of regressions."""
"'EventId' is not a class or namespace i've get this while compiling"""
"version is scanned from tag name"""
"@Vincent-Michael Two time you owned me, I'm so stupid ..."""
"I just spilled out a little for my fallen OmgOmgz :("""
"This sounds like a """"major"""" bug. Would you mind to fill a issue for it an close it ? So we have a better history of what bugs got fixed ?"""
"This is great. API's for the win. I hope we start seeing this trend more and more, rails providing the interfaces, and devs dropping in the implementations based on whatever requirements they have. Can't install Redis in your stack? use delayed job. nee"""
"Sadly not, the assignment works, but then after the code has executed the assigned value is lost again :("""
"move it to namespaces like `lib/tasks/gitlab/update_hooks.rake` and also include it to gitlab:app:setup"""
"omg qaston this is awesome!"""
"Im So Confused Right Now """
"As one of those """"stupid server admins"""" many are so fond of bashing, I applaud this change. What does this means to me, as an admin? * I can see instantly which plugins may break between Minecraft updates. This allows me to update faster than before"
"I'm tested and now get runic power, but if not have a target also get runic power (when damage), doubt is in description: """"Patch 3.1.2 (2009-05-19): If no target is available for Blood Boil to hit, the spell will now cast and consume a blood rune but ge"""
"Aww I was using that :("""
"that seems to do the trick. ... now some cuke is failing, though :/"""
"@jacknagel Got it. But for reinstall to reuse this code, install_formula should really pass on this exception, so I'm planning to put the catch part in the block from install in next commit."""
"encrypted?"""""""
"this was suggested initially but it is a BC break"""
"hello again rbac"""
"True true :)"""
"Please remove the priority for the encoders. The order of these 2 is irrelevant (they are handling different formats anyway) and I don't see a reason to make them use a high priority."""
"rather than add some real html and then selecting it, you should do what you did in your other tests, create some arbitrary html with jQuery, and append it to `#qunit_fixture`. I know that you're just following examples in the tests here, but it's somethi"""
"Then we can be happy that other browsers don't follow the spec, and hope for a fix to the spec instead."""
"Thanks so much for implementing this. <3"""
"@JamesNorris You're an annoying troll, and he was joking about using bytecode bypasses."""
"This is a silly decision that does not represent the majority of the rails community. Official plugin? Absolutely. Core? **No fucking way**."""
" Lutik, you are right. this is not problem base at fact that currently we use 0 as highguid for players, but anyway wrong way extract low guid. Specially because at off servers used <>0 high guid for players and possible we also switch to at some moment."""
"Thank you for that Malcrom :)"""
"well actually this doesn't optimize anything since the profiler is turned off by default. public static boolean a = false; // The first field in MethodProfiler so instead of making this accessible grum just made it worse :("""
"I see. Yeah. It's weird that we call 'em options when they go in and configurations when they come out."""
"Better not give the code sniffer reasons to complain :smile: """
"I have uploaded the libgcrypt-1.4.5.tar.bz2 to our mirrors already, we can look at all those once the restructure is done"""
"aawwww... damn. note to self: don't cherry-pick your own commits from 2010 without thinking... updated: https://github.com/mangos/mangos/commit/f5f52d9a123a3a8f9250634be0fc433f436f4fda"""
"Oh, that's bad. Thanks for reporting, I'll have a look into this. I thought we already got rid of these :("""
"Oops. I'm getting the same thing. :-("""
"Forgot to implement it. :-) Done."""
"`Relative` would suggest to allow accessing the parent node as with `..` in file systems. We should either support such feature or rename the method to `addViolationAtSubPath` in my opinion."""
"This is so badass I don't even know where to begin"""
"@DouweM But if it were his own repositories and posts he would be allowed to delete and commit... And if he created a second account we would have probably violated the ToS as well and somebody would hang him for that... dafuq dude :( bbl..."""
"Don't do this. This will break horribly if node.js ever adds multi-isolate support."""
"Can you please rather give us a test case that causes NullReferenceException? In your code there seems no chance that """"msg == null"""" could occur and I wonder if it really happens. Also it's great if you can follow our coding style, so that we can use """"me"""
"The md5 doesn't seem to be consistent. It changes each time it is downloaded. Is sourceforge the only download url?"""
"@SuperSpyTX or perhaps, just maybe, this is a place for discussion not internet memes."""
"Github ate my comment. Let's try this again: ================================ I don't understand this commit. I just did: <pre><code> >> alternate = ActiveSupport::OrderedHash[1,2,3,4] => #<OrderedHash {1=>2, 3=>4}> >> alternate.class => ActiveSup"""
"You're right, misunderstood the setup. Thanks!"""
"So everything fine here :)?"""
"Oh yeah!"""
"I originally found that CSS snippet on StackOverflow and the comments came with it. I've updated the comments, and added a blurb about why border-box is used. FireFox8 still defines -moz-box-sizing so I left that entry. It appears that the latest Chrome"""