-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some failures against latest specs #10
Comments
Thanks for the reporting. I'll spend some time reading the new spec and see how to adapt to it. |
@pietroppeter I have released v0.4.0, which should fix all the failed test cases reported in this issue. Please let me know if it solves your problem. |
Great job! I will run again and let you know! |
I can confirm all tests are green now: https://pietroppeter.github.io/nblog/drafts/mustache_specs.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I made a document that shows the output of nim-mustache against the specs and I used the latest specs. Here is the document which shows some failures: https://pietroppeter.github.io/nblog/drafts/mustache_specs.html
The failures are due to changes in the latest releases (v1.2.0 of 9 days ago and v1.2.1 of 4 days ago) that introduced additional tests for existing features.
Here are the name of failing tests:
The tests with names starting with Implicit Iterators are failures in the sense that the spec uses a
data
json that is not an object. TheContext
of nim-mustache must have asvalues
field a table. Probably a fix would require to change the type ofvalues
to be aValue
itself (and rename it tovalue
)?For the other 3 failing tests I report here for convenience the data with expected output and output from nim-mustache.
❌ Dotted Names - Context Precedence
Dotted names should be resolved against former resolutions.
Template:
Data:
Expected:
Output:
❌ Variable test
Non-false sections have their value at the top of context, accessible as {{.}} or through the parent context. This gives a simple way to display content conditionally if a variable exists.
Template:
Data:
Expected:
Output:
❌ Deeply Nested Contexts
All elements on the context stack should be accessible.
Template:
Data:
Expected:
Output:
The text was updated successfully, but these errors were encountered: