Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.2.3 improvements. #10

Merged
merged 1 commit into from Dec 7, 2016
Merged

Version 0.2.3 improvements. #10

merged 1 commit into from Dec 7, 2016

Conversation

phpdude
Copy link
Contributor

@phpdude phpdude commented Dec 7, 2016 •
edited

Hi team,

Thank you for your time, you created nice stuff which I had too, but my version was not "plug-and-play", so I spent some time to add functionality and tests to your library. I hope you like it! :)

Please take a look my changes, approve it, merge and publish new version to allow me use it right now! :)

0.2.3

  • Now include function finds parent globals() scope automatically
  • added protection against infinite recursion with tests
  • added tests for stackable settings definition. Check settings example in tests/settings/stacked/.

Thanks for your time.

@phpdude
Copy link
Contributor Author

phpdude commented Dec 7, 2016

You can list me in the authors section if you like my contribution :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 97.826% when pulling 1a20b13 on phpdude:improvements into 4749d2b on sobolevn:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 97.826% when pulling 0623951 on phpdude:improvements into 4749d2b on sobolevn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cbb7324 on phpdude:improvements into 4749d2b on sobolevn:master.

@sobolevn
Copy link
Member

sobolevn commented Dec 7, 2016

That an amazing work! Thanks you! Could you please also add yourself to the authors, so I can squash everything and merge it?

@phpdude
Copy link
Contributor Author

phpdude commented Dec 7, 2016

@sobolevn done!

Also I added remark to README file

https://github.com/sobolevn/django-split-settings/pull/10/files#diff-88b99bb28683bd5b7e3a204826ead112R103

@phpdude
0.2.3
f8864de 
-----

* Now `include` function finds parent `globals()` scope automatically
* added protection against infinite recursion with tests
* added tests for stackable settings definition. Check settings example in tests/settings/stacked/.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f8864de on phpdude:improvements into 4749d2b on sobolevn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f8864de on phpdude:improvements into 4749d2b on sobolevn:master.

@sobolevn sobolevn merged commit 6fedd4c into wemake-services:master Dec 7, 2016
@phpdude
Copy link
Contributor Author

phpdude commented Dec 7, 2016

Will you push new version to pypi?

@sobolevn
Copy link
Member

sobolevn commented Dec 7, 2016

Sure, in a few hours.

@phpdude
Copy link
Contributor Author

phpdude commented Dec 7, 2016

Ah, sorry for the disturb :)

Just checked maybe you forgot it.

@sobolevn
Copy link
Member

sobolevn commented Dec 7, 2016

Done!

@phpdude
Copy link
Contributor Author

phpdude commented Dec 7, 2016

Amazing! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phpdude @coveralls @sobolevn