Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/507 #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix/507 #510

wants to merge 1 commit into from

Conversation

SukiCZ
Copy link
Contributor

@SukiCZ SukiCZ commented Nov 9, 2023

sorry @sobolevn I've realized one thing.

Getting list of paths matching a non-existent pattern, returns empty list, which differs from getting a paths of parent folder (empty string).

>>> import glob

>>> glob.glob('/tmp/None')  # Previous behavior
[]
>>> glob.glob('/tmp/')  # Current behavior
['/tmp/']

This adds a skip to Optional empty values (+unit-test & docs)

@SukiCZ
Copy link
Contributor Author

SukiCZ commented Dec 11, 2023

Hey @sobolevn, I rebased the PR to make latest change more visible.

If it's unclear, without skipping Optional values the code will result to IsADirectoryError as you can see when commenting out the change and running pytest

>               with open(included_file, 'rb') as to_compile:
E               IsADirectoryError: [Errno 21] Is a directory: './tests/settings/merged'

split_settings/tools.py:107: IsADirectoryError

@SukiCZ
Copy link
Contributor Author

SukiCZ commented Mar 27, 2024

@sobolevn any update on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant