Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of PReLU #8

Closed
LehaoLin opened this issue Mar 15, 2024 · 3 comments
Closed

Lack of PReLU #8

LehaoLin opened this issue Mar 15, 2024 · 3 comments

Comments

@LehaoLin
Copy link

Lack of PReLU.circom
reference from pytorch: https://pytorch.org/docs/stable/generated/torch.nn.PReLU.html

@socathie
Copy link
Owner

Would you like to contribute by creating PReLU circuit?

@LehaoLin
Copy link
Author

#9 pass the test. But maybe the logic is not correct. Please check.

@socathie
Copy link
Owner

I see. Actually since zkML currently concerns inference only and not training, PReLU is exactly the same as LeakyReLU? In this case, if having a template named PReLU is a must, I think it will be best for it to include LeakyReLU as a template to avoid duplicate code maintenance in the future.

@socathie socathie closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants