Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Python 3 #81

Closed
2 tasks done
vinayak-mehta opened this issue Aug 30, 2018 · 4 comments
Closed
2 tasks done

Port to Python 3 #81

vinayak-mehta opened this issue Aug 30, 2018 · 4 comments

Comments

@vinayak-mehta
Copy link
Contributor

vinayak-mehta commented Aug 30, 2018

Have to figure out if the following dependencies work as expected, in Python 3:

Thinking of starting with using things from __future__ wherever possible (mostly print, division and unicode_literals), and create a release for Python 2. That should make it easy for us to create a Python 3 release once the deps are sorted.

@vinayak-mehta vinayak-mehta added this to the 0.1.0 milestone Aug 30, 2018
@vinayak-mehta vinayak-mehta mentioned this issue Sep 5, 2018
20 tasks
@vinayak-mehta
Copy link
Contributor Author

Added __future__ imports for division, removing from 0.1.0 milestone.

@vinayak-mehta vinayak-mehta removed this from the 0.1.0 milestone Sep 7, 2018
@vaibhavmule
Copy link
Contributor

vaibhavmule commented Sep 28, 2018

I have never made a project that supports both Python 2.x and Python3.x version,

It will be learning for me, I can help for porting this library to Python3,

Let me know How can I get started?

@vinayak-mehta
Copy link
Contributor Author

vinayak-mehta commented Sep 28, 2018

Hello @vaibhavmule! I'd already created a branch for this locally, let me push it. I've used pdfminer.six instead of pdfminer, and the tests are passing (after some minor modifications). You can check out the following links which show how to write Python 2+3 compatible code:

  1. http://python3porting.com/
  2. http://python-future.org/compatible_idioms.html

You can also look into adding more tests and increase the code coverage, if you're up for it! I will open up an issue and create an initial list of things which should be tested, to which we can both add, and then go from there.

@vaibhavmule
Copy link
Contributor

vaibhavmule commented Sep 28, 2018

Yes that is what I read, test coverage is needed.

LGTM, you can go ahead and create an issue.

And push the branch, may be I can contribute that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants