Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG + 1] Add tests for repr #128

Merged
merged 7 commits into from
Oct 5, 2018
Merged

[MRG + 1] Add tests for repr #128

merged 7 commits into from
Oct 5, 2018

Conversation

vaibhavmule
Copy link
Contributor

No description provided.

@vaibhavmule vaibhavmule changed the title add tests for repr [MRG] add tests for repr Oct 5, 2018
vaibhavmule
vaibhavmule commented Oct 5, 2018
View reviewed changes
tests/test_common.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 5, 2018 •
edited
Loading

Codecov Report

Merging #128 into master will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   84.22%   84.47%   +0.25%     
==========================================
  Files          12       12              
  Lines        1198     1198              
  Branches      288      288              
==========================================
+ Hits         1009     1012       +3     
+ Misses        145      142       -3     
  Partials       44       44
Impacted Files Coverage Δ
camelot/core.py 87.5% <ø> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90aaba6...2e0a80d. Read the comment docs.

@vinayak-mehta
Copy link
Contributor

vinayak-mehta commented Oct 5, 2018 •
edited
Loading

@vaibhavmule Can you also add an assert for the Cell repr? That should cover all reprs.

@vaibhavmule vaibhavmule changed the title [MRG] add tests for repr [WIP] add tests for repr Oct 5, 2018
@vaibhavmule vaibhavmule changed the title [WIP] add tests for repr [MRG] add tests for repr Oct 5, 2018
vinayak-mehta
vinayak-mehta reviewed Oct 5, 2018
View reviewed changes
tests/test_common.py Outdated Show resolved Hide resolved
@vaibhavmule vaibhavmule changed the title [MRG] add tests for repr [WIP] add tests for repr Oct 5, 2018
@vinayak-mehta
Copy link
Contributor

@vaibhavmule Is this ready for merge?

@vaibhavmule vaibhavmule changed the title [WIP] add tests for repr [MRG] add tests for repr Oct 5, 2018
vinayak-mehta
vinayak-mehta approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@vinayak-mehta vinayak-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vinayak-mehta vinayak-mehta changed the title [MRG] add tests for repr [MRG + 1] Add tests for repr Oct 5, 2018
@vinayak-mehta vinayak-mehta merged commit c53ea79 into atlanhq:master Oct 5, 2018
@vinayak-mehta
Copy link
Contributor

@vaibhavmule Thanks for the contribution!

@vaibhavmule vaibhavmule deleted the test-repr branch October 5, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayak-mehta vinayak-mehta vinayak-mehta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavmule @codecov-io @vinayak-mehta