does not work if dialr is not loaded

[renejuan]

I am not sure if this is due to a namespace issue but I noticed that dialr have to be attached before running the phone function.

x <- "888-8989"
myfunc <- function(x) dialr::phone(x, region = "US")

# This does not work
myfunc(x)
# Error in .jcheck() : No running JVM detected. Maybe .jinit() would help.

# This neither
dialr::phone(x, "US")

# It seems by loading the library before performing any operations the problem
# is resolved.
library(dialr)
dialr::phone(x, "US")
myfunc(x)

[gorcha]

Hi!

This is because rJava is only initialised when the package is attached with library(), but not just when the namespace is loaded (i.e. with the :: reference).

See .onAttach() vs .onLoad() here:

dialr/R/zzz.R

Lines 2 to 35 in 398f2c6

	.onLoad <- function(libname, pkgname) {
	op <- options()
	op.dialr <- list(
	dialr.name = "DIALR",
	dialr.home = "AU",
	dialr.format = "E164",
	dialr.locale = "en",
	dialr.show_progress = TRUE
	)
	toset <- !(names(op.dialr) %in% names(op))
	if (any(toset)) options(op.dialr[toset])
	register_s3_method("pillar", "pillar_shaft", "phone")
	register_s3_method("pillar", "type_sum", "phone")
	register_s3_method("pillar", "is_vector_s3", "phone")
	register_s3_method("pillar", "obj_sum", "phone")
	invisible()
	}
	#' @import rJava
	.onAttach <- function(libname, pkgname) {
	rJava::.jpackage("dialrjars")
	rJava::.jpackage(pkgname, lib.loc = libname) # needed to load RInterface.java
	# what's your java version? Need > 1.5.0.
	jversion <- .jcall('java.lang.System','S','getProperty','java.version')
	if (jversion < "1.6.0")
	stop(paste("Your java version is ", jversion,
	". Need 1.6.0 or higher.", sep = ""))
	# initialise PhoneNumberUtil singleton
	invisible(.get_phoneNumberUtil())
	}

When I originally set up dialr I took this approach based on a couple of other Java wrapper packages, but I'm not sure that it has to be away. I'll try moving everything to .onLoad() instead and see if it causes any issues, which should give the behaviour you expect.

[gorcha]

Hi @renejuan, I've made this change and it appears to be working fine.
Thanks for the feedback!