Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning that crops up when using chk_text_nmiss #16

Closed
kinto-b opened this issue Jan 19, 2021 · 1 comment
Closed

Fix warning that crops up when using chk_text_nmiss #16

kinto-b opened this issue Jan 19, 2021 · 1 comment
Assignees
Labels
Task: Bug Something isn't working

Comments

@kinto-b
Copy link
Contributor

kinto-b commented Jan 19, 2021

x <- testdat::chk_nmiss(mtcars$vs)
#> Warning: `chk_nmiss()` is soft-deprecated as of testdat 0.1.0. Use `chk_text_nmiss()` instead.
#> This warning is displayed once per session.

We just need to replace chk_nmiss() with chk_text_nmiss() in the definition of chk_text_nmiss()

testdat/R/chk.R

Lines 64 to 68 in 9f3ef72

#' @rdname chk-generic
#' @export
chk_text_nmiss <- function(x, miss = getOption("testdat.miss_text")) {
!chk_miss(x, miss)
}

@kinto-b kinto-b added the Task: Bug Something isn't working label Jan 19, 2021
@kinto-b kinto-b self-assigned this Jan 19, 2021
@gorcha
Copy link
Collaborator

gorcha commented Jan 20, 2021

Yo!

Yeah the deprecation message is correct, just needs to point to !chk_text_miss(x, miss) instead (my bad!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants