Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

how to do :after :before #4

Open
mcwhittemore opened this issue Nov 11, 2014 · 2 comments
Open

how to do :after :before #4

mcwhittemore opened this issue Nov 11, 2014 · 2 comments

Comments

@mcwhittemore
Copy link
Contributor

As we try playing around with different grid system in react (no css) we need to figure out how to replace the need for :after and :before.

I am currently working on this really simple grid from css-tricks. @totty90 mentioned in material-ui/issues#30 that he might have a solution.

@rickyvetter
Copy link
Contributor

Isn't what we really want the ability to access the shadow DOM? Or do we actually need the ability to use :before and :after?

@rickyvetter
Copy link
Contributor

https://twitter.com/Vjeux/status/532555299002286081
Vjeux's opinion is pro using real DOM elements. That doesn't help us porting over gird systems but it's interesting and in reality it wouldn't be hard to make a div do the work - most of these frameworks are just using before and after to do clearfixing. The generated code wouldn't be pretty but it would work exactly the same way and arguably be more functional in that you could pretty easily switch from a rigid height grid like Bootstrap to something without clearfixes that looks more like Masonry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants